diff options
author | Jacob Garber <jgarber1@ualberta.ca> | 2019-09-06 13:29:33 -0600 |
---|---|---|
committer | Philipp Deppenwiese <zaolin.daisuki@gmail.com> | 2019-09-07 01:02:43 +0000 |
commit | c563d34fc14dfb4e57e1841725dfb778e623e681 (patch) | |
tree | 69dda514f581373dfaaa478ea761b0ec198ed126 /src/superio/ite | |
parent | 5f1786fc9cc543845a070c61d4f2dec2ae39c691 (diff) | |
download | coreboot-c563d34fc14dfb4e57e1841725dfb778e623e681.tar.xz |
security/tpm: Use correct hash digest lengths
TPMU_HA is a union of all the different hash digests, and so
sizeof(TPMU_HA) evaluates to 64 (the size of the largest one). This will
lead to out-of-bounds writes when copying smaller digests, so use the
specific digest size for each algorithm.
Change-Id: Ic9101f157d5a19836b200ecd99f060de552498d2
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 14049{49,50,51,52,53,54,55,56,57,58,60,61,62}
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35287
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Diffstat (limited to 'src/superio/ite')
0 files changed, 0 insertions, 0 deletions