diff options
| author | Rudolf Marek <r.marek@assembler.cz> | 2011-02-19 14:51:31 +0000 |
|---|---|---|
| committer | Rudolf Marek <r.marek@assembler.cz> | 2011-02-19 14:51:31 +0000 |
| commit | 0c8e664713d4dc726bedb5ba0b2e356eed9ae14c (patch) | |
| tree | a81752632b470dfcb252e15865c3f2aa7de9bfe0 /src/superio/ite | |
| parent | b8cdd9b4506309ced1529862d7598131a5cb4ea7 (diff) | |
| download | coreboot-0c8e664713d4dc726bedb5ba0b2e356eed9ae14c.tar.xz | |
It turns out that the code which enables specific LDN is somewhat buggy.
Instead of enable the device the device gets disabled. However after some time the serial line gets back, most likely some "enable resources" might fix it.
I'm attaching patch which somewhat fixes the problem and changes the function to look same in all superio code. Some boards even did not convert the dev->enabled to 0,1 values.
Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6373 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/ite')
| -rw-r--r-- | src/superio/ite/it8712f/superio.c | 2 | ||||
| -rw-r--r-- | src/superio/ite/it8716f/superio.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/superio/ite/it8712f/superio.c b/src/superio/ite/it8712f/superio.c index 67bbac4403..c84a92916f 100644 --- a/src/superio/ite/it8712f/superio.c +++ b/src/superio/ite/it8712f/superio.c @@ -99,7 +99,7 @@ static void it8712f_pnp_enable(device_t dev) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); - pnp_set_enable(dev, dev->enabled); + pnp_set_enable(dev, !!dev->enabled); pnp_exit_ext_func_mode(dev); } diff --git a/src/superio/ite/it8716f/superio.c b/src/superio/ite/it8716f/superio.c index 54e640f913..c7109465b5 100644 --- a/src/superio/ite/it8716f/superio.c +++ b/src/superio/ite/it8716f/superio.c @@ -122,7 +122,7 @@ static void it8716f_pnp_enable(device_t dev) { pnp_enter_ext_func_mode(dev); pnp_set_logical_device(dev); - pnp_set_enable(dev, dev->enabled); + pnp_set_enable(dev, !!dev->enabled); pnp_exit_ext_func_mode(dev); } |