diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
commit | a69d978be8a068944466e776de87527fb104a878 (patch) | |
tree | 8acf4247e3104ad9ccb940568a81e472105a674b /src/superio/nsc/pc97317/pc97317_early_serial.c | |
parent | 2e9323e5bef293c051d9fd982214e6db2e3305ee (diff) | |
download | coreboot-a69d978be8a068944466e776de87527fb104a878.tar.xz |
C and other Super I/O cosmetic fixes.
- Random coding style, whitespace and cosmetic fixes.
- Consistently use the same spacing and 4-hexdigit port number format
in the pnp_dev_info[] arrays.
- Drop dead/unused code and less useful comments.
- Add missing "(C)" characters and copyright years.
- Shorten and simplify some code snippets.
- Use u8/u16/etc. everywhere.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6073 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/nsc/pc97317/pc97317_early_serial.c')
-rw-r--r-- | src/superio/nsc/pc97317/pc97317_early_serial.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/src/superio/nsc/pc97317/pc97317_early_serial.c b/src/superio/nsc/pc97317/pc97317_early_serial.c index 175d490f1b..00a92b3be6 100644 --- a/src/superio/nsc/pc97317/pc97317_early_serial.c +++ b/src/superio/nsc/pc97317/pc97317_early_serial.c @@ -24,28 +24,24 @@ #define PM_DEV PNP_DEV(0x2e, PC97317_PM) #define PM_BASE 0xe8 -/* The pc97317 needs clocks to be set up before the serial port will operate */ - -static void pc97317_enable_serial(device_t dev, unsigned iobase) +/* The PC97317 needs clocks to be set up before the serial port will operate. */ +static void pc97317_enable_serial(device_t dev, u16 iobase) { - /* Set base address of power management unit */ - + /* Set base address of power management unit. */ pnp_set_logical_device(PM_DEV); pnp_set_enable(dev, 0); pnp_set_iobase(dev, PNP_IDX_IO0, PM_BASE); pnp_set_enable(dev, 1); - /* Use on-chip clock multiplier */ - + /* Use on-chip clock multiplier. */ outb(0x03, PM_BASE); outb(inb(PM_BASE + 1) | 0x07, PM_BASE + 1); - /* Wait for the clock to stabilise */ + /* Wait for the clock to stabilise. */ while(!(inb(PM_BASE + 1) & 0x80)) ; - /* Set the base address of the port */ - + /* Set the base address of the port. */ pnp_set_logical_device(dev); pnp_set_enable(dev, 0); pnp_set_iobase(dev, PNP_IDX_IO0, iobase); |