diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-11-15 19:35:14 +0000 |
| commit | a69d978be8a068944466e776de87527fb104a878 (patch) | |
| tree | 8acf4247e3104ad9ccb940568a81e472105a674b /src/superio/smsc/sio10n268 | |
| parent | 2e9323e5bef293c051d9fd982214e6db2e3305ee (diff) | |
| download | coreboot-a69d978be8a068944466e776de87527fb104a878.tar.xz | |
C and other Super I/O cosmetic fixes.
- Random coding style, whitespace and cosmetic fixes.
- Consistently use the same spacing and 4-hexdigit port number format
in the pnp_dev_info[] arrays.
- Drop dead/unused code and less useful comments.
- Add missing "(C)" characters and copyright years.
- Shorten and simplify some code snippets.
- Use u8/u16/etc. everywhere.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6073 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/superio/smsc/sio10n268')
| -rw-r--r-- | src/superio/smsc/sio10n268/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/superio/smsc/sio10n268/sio10n268.c | 9 |
2 files changed, 4 insertions, 6 deletions
diff --git a/src/superio/smsc/sio10n268/Makefile.inc b/src/superio/smsc/sio10n268/Makefile.inc index eeefa2d431..fdde560127 100644 --- a/src/superio/smsc/sio10n268/Makefile.inc +++ b/src/superio/smsc/sio10n268/Makefile.inc @@ -18,3 +18,4 @@ ## ramstage-$(CONFIG_SUPERIO_SMSC_SIO10N268) += sio10n268.c + diff --git a/src/superio/smsc/sio10n268/sio10n268.c b/src/superio/smsc/sio10n268/sio10n268.c index 477ea9651a..66e3c87e56 100644 --- a/src/superio/smsc/sio10n268/sio10n268.c +++ b/src/superio/smsc/sio10n268/sio10n268.c @@ -27,13 +27,10 @@ static void init(device_t dev) { - struct superio_smsc_sio10n268_config *conf; + struct superio_smsc_sio10n268_config *conf = dev->chip_info; - if (!dev->enabled) { + if (!dev->enabled) return; - } - - conf = dev->chip_info; switch (dev->path.pnp.device) { case SIO10N268_FDC: /* TODO. */ @@ -58,7 +55,7 @@ static struct device_operations ops = { /* TODO: FDC, PP, AUX. */ static struct pnp_info pnp_dev_info[] = { - { &ops, SIO10N268_KBDC, PNP_IO0 | PNP_IO1, { 0x7f8, 0 }, { 0x7f8, 0x4}, }, + { &ops, SIO10N268_KBDC, PNP_IO0 | PNP_IO1, {0x07f8, 0}, {0x07f8, 4}, }, }; static void enable_dev(struct device *dev) |