summaryrefslogtreecommitdiff
path: root/src/superio/smsc/smscsuperio
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2013-06-15 19:58:35 +0200
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-06-17 21:42:21 +0200
commit0b2ee9391079a5092eb99dce764e3836eeb92cd9 (patch)
tree6799e12b9b9bb982e5922be6e999081b7a63bacd /src/superio/smsc/smscsuperio
parent13dc976a5288899756ec6e5d53b51b1ddf64b389 (diff)
downloadcoreboot-0b2ee9391079a5092eb99dce764e3836eeb92cd9.tar.xz
pnp: Remove now plain wrappers for default PnP functions
After removing the enter()/exit() functions for configuration mode, most wrappers for our standard PnP functions just call the underlying default implementation. Remove those with a little cocci: @ op_match @ identifier op; identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$"; type device_t; identifier dev; @@ static void op(device_t dev) { pnp_op(dev); } @@ identifier op_match.op; @@ -op(...) {...} /* Three rules to match the alignment, hmmp... */ @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .set_resources = op, + .set_resources = pnp_op, }; @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .enable_resources = op, + .enable_resources = pnp_op, }; @@ identifier op_match.op, op_match.pnp_op; identifier ops; @@ struct device_operations ops = { - .enable = op, + .enable = pnp_op, }; Change-Id: Idc0e52c7e3600a01f3b6a4e17763557b271b481e Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: http://review.coreboot.org/3483 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Marc Jones <marc.jones@se-eng.com> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/superio/smsc/smscsuperio')
-rw-r--r--src/superio/smsc/smscsuperio/superio.c29
1 files changed, 3 insertions, 26 deletions
diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c
index 9af67a1c02..d45a9671c1 100644
--- a/src/superio/smsc/smscsuperio/superio.c
+++ b/src/superio/smsc/smscsuperio/superio.c
@@ -169,29 +169,6 @@ static void smsc_pnp_exit_conf_state(device_t dev)
outb(0xaa, dev->path.pnp.port);
}
-/** Wrapper for pnp_set_resources(). */
-static void smsc_pnp_set_resources(device_t dev)
-{
- pnp_set_resources(dev);
-}
-
-/** Wrapper for pnp_enable_resources(). */
-static void smsc_pnp_enable_resources(device_t dev)
-{
- pnp_enable_resources(dev);
-}
-
-/**
- * If so configured, enable the specified device, otherwise
- * explicitly disable it.
- *
- * @param dev The device to use.
- */
-static void smsc_pnp_enable(device_t dev)
-{
- pnp_alt_enable(dev);
-}
-
/**
* Initialize those logical devices which need a special init.
*
@@ -230,9 +207,9 @@ static const struct pnp_mode_ops pnp_conf_mode_ops = {
/** Standard device operations. */
static struct device_operations ops = {
.read_resources = pnp_read_resources,
- .set_resources = smsc_pnp_set_resources,
- .enable_resources = smsc_pnp_enable_resources,
- .enable = smsc_pnp_enable,
+ .set_resources = pnp_set_resources,
+ .enable_resources = pnp_enable_resources,
+ .enable = pnp_alt_enable,
.init = smsc_init,
.ops_pnp_mode = &pnp_conf_mode_ops,
};