summaryrefslogtreecommitdiff
path: root/src/superio/smsc/smscsuperio
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2013-06-15 19:33:15 +0200
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-06-17 21:42:06 +0200
commit13dc976a5288899756ec6e5d53b51b1ddf64b389 (patch)
treeccee0cfc08e48c6b223c7f20289b11043d64de24 /src/superio/smsc/smscsuperio
parentdd4715b6a5beca80ce9655f8711327a83d05b416 (diff)
downloadcoreboot-13dc976a5288899756ec6e5d53b51b1ddf64b389.tar.xz
pnp: Register implementations of enter/exit config state
Find all the (ramstage) implementations of enter()/exit() functions for the configuration state, register and call them through the new struct pnp_mode_ops. As our standard PnP functions are aware of the pnp_mode_ops, it's not necessary to call enter()/exit() around them anymore. Patch generated with the cocci below. It's not perfect. The movement of the enter()/exit() calls is somehow fragile. So I checked the remaining calls for sense, and changed some empty lines. Also a duplicate insertion of pnp_conf_mode_ops had to be removed. /* Try to find enter and exit functions by their outb() structure and their usage around calls to our standard pnp functions: */ @ enter_match @ identifier enter; identifier dev; type device_t; @@ void enter(device_t dev) { <... outb(..., dev->path.pnp.port); ...> } @ exit_match @ identifier exit; identifier dev; type device_t; @@ void exit(device_t dev) { <... outb(..., dev->path.pnp.port); ...> } @ pnp_match @ identifier op; identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$"; identifier enter_match.enter, exit_match.exit; type device_t; identifier dev; @@ void op(device_t dev) { ... enter(dev); ... pnp_op(dev); ... exit(dev); ... } /* Now add enter/exit to a pnp_mode_ops structure: */ @ depends on pnp_match @ identifier enter_match.enter; identifier exit_match.exit; identifier ops; @@ +static const struct pnp_mode_ops pnp_conf_mode_ops = { + .enter_conf_mode = enter, + .exit_conf_mode = exit, +}; + struct device_operations ops = { ..., + .ops_pnp_mode = &pnp_conf_mode_ops, }; /* Match against the new structure as we change the code and the above matches might not work anymore: */ @ mode_match @ identifier enter, exit, ops; @@ struct pnp_mode_ops ops = { .enter_conf_mode = enter, .exit_conf_mode = exit, }; /* Replace enter()/enter() calls with new standard calls (e.g. pnp_enter_conf_mode()): */ @@ identifier mode_match.enter; expression e; @@ -enter(e) +pnp_enter_conf_mode(e) @@ identifier mode_match.exit; expression e; @@ -exit(e) +pnp_exit_conf_mode(e) /* If there are calls to standard PnP functions, (re)move the enter()/exit() calls around them: */ @@ identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$"; expression e; @@ -pnp_enter_conf_mode(e); pnp_op(e); +pnp_enter_conf_mode(e); ... pnp_exit_conf_mode(e); @@ identifier pnp_op =~ "^pnp_((alt_|)enable|(set|enable)_resources)$"; expression e; @@ pnp_enter_conf_mode(e); ... +pnp_exit_conf_mode(e); pnp_op(e); -pnp_exit_conf_mode(e); @@ expression e; @@ -pnp_enter_conf_mode(e); -pnp_exit_conf_mode(e); Change-Id: I5c04b0c6a8f01a30bc25fe195797c02e75b6c276 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: http://review.coreboot.org/3482 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/superio/smsc/smscsuperio')
-rw-r--r--src/superio/smsc/smscsuperio/superio.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c
index cdd223b489..9af67a1c02 100644
--- a/src/superio/smsc/smscsuperio/superio.c
+++ b/src/superio/smsc/smscsuperio/superio.c
@@ -172,17 +172,13 @@ static void smsc_pnp_exit_conf_state(device_t dev)
/** Wrapper for pnp_set_resources(). */
static void smsc_pnp_set_resources(device_t dev)
{
- smsc_pnp_enter_conf_state(dev);
pnp_set_resources(dev);
- smsc_pnp_exit_conf_state(dev);
}
/** Wrapper for pnp_enable_resources(). */
static void smsc_pnp_enable_resources(device_t dev)
{
- smsc_pnp_enter_conf_state(dev);
pnp_enable_resources(dev);
- smsc_pnp_exit_conf_state(dev);
}
/**
@@ -193,9 +189,7 @@ static void smsc_pnp_enable_resources(device_t dev)
*/
static void smsc_pnp_enable(device_t dev)
{
- smsc_pnp_enter_conf_state(dev);
pnp_alt_enable(dev);
- smsc_pnp_exit_conf_state(dev);
}
/**
@@ -228,6 +222,11 @@ static void smsc_init(device_t dev)
}
}
+static const struct pnp_mode_ops pnp_conf_mode_ops = {
+ .enter_conf_mode = smsc_pnp_enter_conf_state,
+ .exit_conf_mode = smsc_pnp_exit_conf_state,
+};
+
/** Standard device operations. */
static struct device_operations ops = {
.read_resources = pnp_read_resources,
@@ -235,6 +234,7 @@ static struct device_operations ops = {
.enable_resources = smsc_pnp_enable_resources,
.enable = smsc_pnp_enable,
.init = smsc_init,
+ .ops_pnp_mode = &pnp_conf_mode_ops,
};
/**
@@ -288,10 +288,10 @@ static void enable_dev(device_t dev)
if (first_time) {
/* Read the device ID and revision of the Super I/O chip. */
- smsc_pnp_enter_conf_state(dev);
+ pnp_enter_conf_mode(dev);
superio_id = pnp_read_config(dev, DEVICE_ID_REG);
superio_rev = pnp_read_config(dev, DEVICE_REV_REG);
- smsc_pnp_exit_conf_state(dev);
+ pnp_exit_conf_mode(dev);
/* TODO: Error handling? */