diff options
author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-04-03 14:30:58 +1100 |
---|---|---|
committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2014-04-06 06:08:20 +0200 |
commit | 793a429eb57d105ca7bdf8c25cb1066678c2721d (patch) | |
tree | 6d4ea209156a82095a34f712f6b7776ca23e237b /src/superio/winbond | |
parent | 59674d25be5b5090e01cae7000c2065d1a0c5abd (diff) | |
download | coreboot-793a429eb57d105ca7bdf8c25cb1066678c2721d.tar.xz |
superio/winbond/w83627ehg: Avoid .c includes
Following the same reasoning as commit
d304331 superio/fintek/f81865f: Avoid .c includes
Clean up the early_serial #include directives in mainboard/romstage
code.
Change-Id: Ib3a12fb8160729008bdaa8026365675a11325da0
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5448
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'src/superio/winbond')
-rw-r--r-- | src/superio/winbond/w83627ehg/Makefile.inc | 3 | ||||
-rw-r--r-- | src/superio/winbond/w83627ehg/early_init.c | 2 | ||||
-rw-r--r-- | src/superio/winbond/w83627ehg/early_serial.c | 5 | ||||
-rw-r--r-- | src/superio/winbond/w83627ehg/w83627ehg.h | 5 |
4 files changed, 10 insertions, 5 deletions
diff --git a/src/superio/winbond/w83627ehg/Makefile.inc b/src/superio/winbond/w83627ehg/Makefile.inc index 33ec4dc64f..19f069f125 100644 --- a/src/superio/winbond/w83627ehg/Makefile.inc +++ b/src/superio/winbond/w83627ehg/Makefile.inc @@ -19,5 +19,6 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += early_init.c +romstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += early_serial.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83627EHG) += superio.c - diff --git a/src/superio/winbond/w83627ehg/early_init.c b/src/superio/winbond/w83627ehg/early_init.c index 7be5e37ad3..d767aa03a4 100644 --- a/src/superio/winbond/w83627ehg/early_init.c +++ b/src/superio/winbond/w83627ehg/early_init.c @@ -19,8 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <stdint.h> #include <arch/io.h> +#include <device/pnp.h> #include "w83627ehg.h" void w83627ehg_disable_dev(device_t dev) diff --git a/src/superio/winbond/w83627ehg/early_serial.c b/src/superio/winbond/w83627ehg/early_serial.c index 1a895c6bd9..84eb12708b 100644 --- a/src/superio/winbond/w83627ehg/early_serial.c +++ b/src/superio/winbond/w83627ehg/early_serial.c @@ -20,16 +20,17 @@ */ #include <arch/io.h> +#include <device/pnp.h> #include "w83627ehg.h" -static void pnp_enter_ext_func_mode(device_t dev) +void pnp_enter_ext_func_mode(device_t dev) { u16 port = dev >> 8; outb(0x87, port); outb(0x87, port); } -static void pnp_exit_ext_func_mode(device_t dev) +void pnp_exit_ext_func_mode(device_t dev) { u16 port = dev >> 8; outb(0xaa, port); diff --git a/src/superio/winbond/w83627ehg/w83627ehg.h b/src/superio/winbond/w83627ehg/w83627ehg.h index c982603315..e574cf3f16 100644 --- a/src/superio/winbond/w83627ehg/w83627ehg.h +++ b/src/superio/winbond/w83627ehg/w83627ehg.h @@ -60,4 +60,7 @@ void w83627ehg_disable_dev(device_t dev); void w83627ehg_enable_serial(device_t dev, u16 iobase); #endif -#endif +void pnp_enter_ext_func_mode(device_t dev); +void pnp_exit_ext_func_mode(device_t dev); + +#endif /* SUPERIO_WINBOND_W83627EHG_W83627EHG_H */ |