diff options
| author | Jakub Czapiga <jacz@semihalf.com> | 2021-02-19 11:44:22 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-22 11:21:55 +0000 |
| commit | 61fcb7e9654634cfe0c8a7bf56581fb54d943bd8 (patch) | |
| tree | b65b1a743c85294bc37e1ca7fe8160eeab741073 /src/superio | |
| parent | 7f4c30c1d5c16539faf564d38ebbc695bca8836a (diff) | |
| download | coreboot-61fcb7e9654634cfe0c8a7bf56581fb54d943bd8.tar.xz | |
acpi/acpigen.h: Add more intuitive AML package closing functions
Until now every AML package had to be closed using acpigen_pop_len().
This commit introduces set of package closing functions corresponding
with their opening function names. For example acpigen_write_if()
opens if-statement package, acpigen_write_if_end() closes it.
Now acpigen_write_else() closes previously opened acpigen_write_if(),
so acpigen_pop_len() is not required before it.
Signed-off-by: Jakub Czapiga <jacz@semihalf.com>
Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50910
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lance Zhao
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/superio')
| -rw-r--r-- | src/superio/nuvoton/npcd378/superio.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/superio/nuvoton/npcd378/superio.c b/src/superio/nuvoton/npcd378/superio.c index b7f98af66b..801592d234 100644 --- a/src/superio/nuvoton/npcd378/superio.c +++ b/src/superio/nuvoton/npcd378/superio.c @@ -248,7 +248,6 @@ static void npcd378_ssdt_pwr(const struct device *dev) acpigen_write_integer(0xE8); acpigen_emit_namestring("^GPE2"); - acpigen_pop_len(); /* Pop If */ acpigen_write_else(); acpigen_emit_byte(AND_OP); @@ -268,7 +267,6 @@ static void npcd378_ssdt_pwr(const struct device *dev) acpigen_write_integer(0x10); acpigen_emit_namestring("^GPE2"); - acpigen_pop_len(); /* Pop If */ acpigen_write_else(); acpigen_emit_byte(AND_OP); |