diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-08-02 20:45:13 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-08-09 10:06:13 +0200 |
| commit | 4e9f5e3f36ec5b497a74e5da0c202c1b62f9e620 (patch) | |
| tree | 334c25db0c2ac809ddbf42fbcf34d1d31e729a74 /src/superio | |
| parent | c14e961f239adb3635fb47ad4e4c5891b3b09a29 (diff) | |
| download | coreboot-4e9f5e3f36ec5b497a74e5da0c202c1b62f9e620.tar.xz | |
superio/smsc/sio1036: Clean up RAMstage superio.c component
Remove spurious includes, unused variables and some wasted new lines.
Re-organise things to be consistent with other superio's.
Change-Id: I959bab2f7a83a1b9160d7f010a0de9638b30cf07
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6465
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Diffstat (limited to 'src/superio')
| -rw-r--r-- | src/superio/smsc/sio1036/superio.c | 42 |
1 files changed, 13 insertions, 29 deletions
diff --git a/src/superio/smsc/sio1036/superio.c b/src/superio/smsc/sio1036/superio.c index d2bfd8ddd3..e9ed6c3fbf 100644 --- a/src/superio/smsc/sio1036/superio.c +++ b/src/superio/smsc/sio1036/superio.c @@ -24,20 +24,16 @@ #include <device/pnp.h> #include <superio/conf_mode.h> #include <console/console.h> -#include <device/smbus.h> -#include <string.h> -#include <pc80/keyboard.h> #include <stdlib.h> -#include "sio1036.h" -/* Forward declarations */ -static void enable_dev(device_t dev); -static void sio1036_init(device_t dev); +#include "sio1036.h" -struct chip_operations superio_smsc_sio1036_ops = { - CHIP_NAME("SMSC SIO1036 Super I/O") - .enable_dev = enable_dev -}; +static void sio1036_init(device_t dev) +{ + if (!dev->enabled) { + return; + } +} static struct device_operations ops = { .read_resources = pnp_read_resources, @@ -49,27 +45,15 @@ static struct device_operations ops = { }; static struct pnp_info pnp_dev_info[] = { - {}, + { &ops, SIO1036_SP1, PNP_IO0 | PNP_IRQ0, {0x07f8, 0}, }, }; static void enable_dev(device_t dev) { - pnp_enable_devices(dev, &pnp_ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); + pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } -static void sio1036_init(device_t dev) -{ - struct resource *res0, *res1; - - - - if (!dev->enabled) { - return; - } - - switch(dev->path.pnp.device) { - - default: - break; - } -} +struct chip_operations superio_smsc_sio1036_ops = { + CHIP_NAME("SMSC SIO1036 Super I/O") + .enable_dev = enable_dev +}; |