diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-06-01 18:04:05 +1000 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-06-03 09:35:38 +0200 |
| commit | 1b3acb13e49753e53192d3e5b939713329d0d205 (patch) | |
| tree | 64ff2b240afcfb63e0c4f4b86859f6ce8404e7b2 /src/superio | |
| parent | d235da108b38ad45f20c3e556e630b10fb16634e (diff) | |
| download | coreboot-1b3acb13e49753e53192d3e5b939713329d0d205.tar.xz | |
superio/ite/it8772f: Move towards removing #include .c
Move samsung/stumpy board towards generic romstage component and away
from poorly written hard-coded model specific Super I/O component. This
is an incremental step towards getting obj-level abstraction between
board and Super I/O.
Change-Id: I358c5abef85c2ffa1b7178025cde8834a35b0a51
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5899
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/superio')
| -rw-r--r-- | src/superio/ite/it8772f/early_serial.c | 21 | ||||
| -rw-r--r-- | src/superio/ite/it8772f/it8772f.h | 10 |
2 files changed, 7 insertions, 24 deletions
diff --git a/src/superio/ite/it8772f/early_serial.c b/src/superio/ite/it8772f/early_serial.c index 8bf2964a50..e9db117eae 100644 --- a/src/superio/ite/it8772f/early_serial.c +++ b/src/superio/ite/it8772f/early_serial.c @@ -22,6 +22,8 @@ #include <device/pnp_def.h> #include "it8772f.h" +/* NOTICE: This file is deprecated, use ite/common instead */ + /* The base address is 0x2e or 0x4e, depending on config bytes. */ #define SIO_BASE IT8772F_BASE #define SIO_INDEX SIO_BASE @@ -85,25 +87,6 @@ void it8772f_enable_3vsbsw(void) it8772f_exit_conf(); } -void it8772f_kill_watchdog(void) -{ - it8772f_enter_conf(); - it8772f_sio_write(IT8772F_CONFIG_REG_LDN, IT8772F_GPIO); - it8772f_sio_write(IT8772F_CONFIG_REG_WATCHDOG, 0x00); - it8772f_exit_conf(); -} - -/* Enable the serial port(s). */ -void it8772f_enable_serial(device_t dev, u16 iobase) -{ - it8772f_enter_conf(); - it8772f_sio_write(IT8772F_CONFIG_REG_LDN, dev & 0xff); - it8772f_sio_write(PNP_IDX_IO0, (iobase >> 8) & 0xff); - it8772f_sio_write(PNP_IDX_IO0+1, iobase & 0xff); - it8772f_sio_write(PNP_IDX_EN, 1); - it8772f_exit_conf(); -} - /* Set AC resume to be up to the Southbridge */ void it8772f_ac_resume_southbridge(void) { diff --git a/src/superio/ite/it8772f/it8772f.h b/src/superio/ite/it8772f/it8772f.h index f881d7a92a..3d45f095c1 100644 --- a/src/superio/ite/it8772f/it8772f.h +++ b/src/superio/ite/it8772f/it8772f.h @@ -18,9 +18,10 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_ITE_IT8772F_IT8772F_H -#define SUPERIO_ITE_IT8772F_IT8772F_H +#ifndef SUPERIO_ITE_IT8772F_H +#define SUPERIO_ITE_IT8772F_H +/* FIXME: SUPERIO include.c */ #define IT8772F_BASE 0x2e #define IT8772F_FDC 0x00 /* Floppy disk controller */ @@ -107,11 +108,10 @@ u8 it8772f_sio_read(u8 index); void it8772f_sio_write(u8 index, u8 value); -void it8772f_enable_serial(device_t dev, u16 iobase); -void it8772f_kill_watchdog(void); void it8772f_24mhz_clkin(void); void it8772f_enable_3vsbsw(void); void it8772f_ac_resume_southbridge(void); void it8772f_gpio_setup(int set, u8 func_select, u8 polarity, u8 pullup, u8 output, u8 enable); -#endif + +#endif /* SUPERIO_ITE_IT8772F_H */ |