diff options
| author | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-27 11:32:38 -0800 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2012-11-28 07:57:17 +0100 |
| commit | 5079a0d32f2824445cf593dfbcb65598eaa97dee (patch) | |
| tree | 2e6edd336c00f1f3e4937410a9be9537553702be /src/superio | |
| parent | acf443191bd035c26ee89c3ca56f065a5111901b (diff) | |
| download | coreboot-5079a0d32f2824445cf593dfbcb65598eaa97dee.tar.xz | |
Remove assembly coded log2 function
As we move to supporting other systems we need to get rid of assembly
where we can. The log2 function in src/lib is identical to the assembly
one (tested for all 32-bit signed integers :-) and takes about 10 ns
to run as opposed to 5ns for the non-portable assembly version. While speed
is good, I think we can spare the 15 ns or so we add to boot time
by using the C version only.
Change-Id: Icafa565eae282c85fa5fc01b3bd1f110cd9aaa91
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: http://review.coreboot.org/1928
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/superio')
28 files changed, 1 insertions, 28 deletions
diff --git a/src/superio/nsc/pc8374/superio.c b/src/superio/nsc/pc8374/superio.c index d5060c4d05..a018766f24 100644 --- a/src/superio/nsc/pc8374/superio.c +++ b/src/superio/nsc/pc8374/superio.c @@ -24,7 +24,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87351/superio.c b/src/superio/nsc/pc87351/superio.c index 259430e0f5..35725d654b 100644 --- a/src/superio/nsc/pc87351/superio.c +++ b/src/superio/nsc/pc87351/superio.c @@ -24,7 +24,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87360/superio.c b/src/superio/nsc/pc87360/superio.c index 5da68e2c11..0a67dcfd3e 100644 --- a/src/superio/nsc/pc87360/superio.c +++ b/src/superio/nsc/pc87360/superio.c @@ -24,7 +24,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87366/superio.c b/src/superio/nsc/pc87366/superio.c index b5f28700ec..9b58df69e6 100644 --- a/src/superio/nsc/pc87366/superio.c +++ b/src/superio/nsc/pc87366/superio.c @@ -24,7 +24,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87382/superio.c b/src/superio/nsc/pc87382/superio.c index 9d4bee0f7a..3c714a6574 100644 --- a/src/superio/nsc/pc87382/superio.c +++ b/src/superio/nsc/pc87382/superio.c @@ -23,7 +23,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87384/superio.c b/src/superio/nsc/pc87384/superio.c index 39177fd7d2..4b1963cd5d 100644 --- a/src/superio/nsc/pc87384/superio.c +++ b/src/superio/nsc/pc87384/superio.c @@ -23,7 +23,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87392/superio.c b/src/superio/nsc/pc87392/superio.c index 81c679c36c..8a2e5c80a5 100644 --- a/src/superio/nsc/pc87392/superio.c +++ b/src/superio/nsc/pc87392/superio.c @@ -23,7 +23,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <stdlib.h> #include "pc87392.h" diff --git a/src/superio/nsc/pc87417/superio.c b/src/superio/nsc/pc87417/superio.c index 9cd0e6bd4d..a9e8823011 100644 --- a/src/superio/nsc/pc87417/superio.c +++ b/src/superio/nsc/pc87417/superio.c @@ -25,7 +25,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/nsc/pc87427/superio.c b/src/superio/nsc/pc87427/superio.c index 3646fd1e1a..f2e8d9fdb9 100644 --- a/src/superio/nsc/pc87427/superio.c +++ b/src/superio/nsc/pc87427/superio.c @@ -24,7 +24,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <stdlib.h> #include "chip.h" #include "pc87427.h" diff --git a/src/superio/nuvoton/wpcm450/superio.c b/src/superio/nuvoton/wpcm450/superio.c index 879f40591e..5ce1d2a1be 100644 --- a/src/superio/nuvoton/wpcm450/superio.c +++ b/src/superio/nuvoton/wpcm450/superio.c @@ -23,7 +23,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/renesas/m3885x/superio.c b/src/superio/renesas/m3885x/superio.c index 1a5fbe6277..a098493a9d 100644 --- a/src/superio/renesas/m3885x/superio.c +++ b/src/superio/renesas/m3885x/superio.c @@ -23,7 +23,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <assert.h> #include <stdlib.h> diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c index c4fde95960..405b90e343 100644 --- a/src/superio/smsc/kbc1100/superio.c +++ b/src/superio/smsc/kbc1100/superio.c @@ -25,7 +25,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47b272/superio.c b/src/superio/smsc/lpc47b272/superio.c index f57c306d98..15e486c202 100644 --- a/src/superio/smsc/lpc47b272/superio.c +++ b/src/superio/smsc/lpc47b272/superio.c @@ -29,7 +29,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47b397/superio.c b/src/superio/smsc/lpc47b397/superio.c index fa549db46b..c83ab3438b 100644 --- a/src/superio/smsc/lpc47b397/superio.c +++ b/src/superio/smsc/lpc47b397/superio.c @@ -26,7 +26,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47m10x/superio.c b/src/superio/smsc/lpc47m10x/superio.c index 3d6a8ed1d7..b422ea0854 100644 --- a/src/superio/smsc/lpc47m10x/superio.c +++ b/src/superio/smsc/lpc47m10x/superio.c @@ -28,7 +28,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47m15x/superio.c b/src/superio/smsc/lpc47m15x/superio.c index 222e3c9eec..c3117b23eb 100644 --- a/src/superio/smsc/lpc47m15x/superio.c +++ b/src/superio/smsc/lpc47m15x/superio.c @@ -25,7 +25,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c index 2658831bcd..d6c153d33a 100644 --- a/src/superio/smsc/lpc47n217/superio.c +++ b/src/superio/smsc/lpc47n217/superio.c @@ -29,7 +29,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <assert.h> #include <stdlib.h> diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c index a241eb6d36..2f877a0d80 100644 --- a/src/superio/smsc/lpc47n227/superio.c +++ b/src/superio/smsc/lpc47n227/superio.c @@ -26,7 +26,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <assert.h> #include <stdlib.h> diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c index 070871d106..0de06f8f32 100644 --- a/src/superio/smsc/mec1308/superio.c +++ b/src/superio/smsc/mec1308/superio.c @@ -25,7 +25,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <pc80/keyboard.h> #include <stdlib.h> #include "chip.h" diff --git a/src/superio/smsc/sch4037/superio.c b/src/superio/smsc/sch4037/superio.c index eebcacd60e..b99d7f7bc6 100644 --- a/src/superio/smsc/sch4037/superio.c +++ b/src/superio/smsc/sch4037/superio.c @@ -25,7 +25,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/smsc/sio1036/superio.c b/src/superio/smsc/sio1036/superio.c index 2522d92403..d1acb90b04 100644 --- a/src/superio/smsc/sio1036/superio.c +++ b/src/superio/smsc/sio1036/superio.c @@ -25,7 +25,6 @@ #include <console/console.h> #include <device/smbus.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index 85747f26eb..f40bec6535 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -26,7 +26,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <pc80/mc146818rtc.h> diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c index 1d1b169e83..da286a0e1c 100644 --- a/src/superio/winbond/w83627hf/superio.c +++ b/src/superio/winbond/w83627hf/superio.c @@ -26,7 +26,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <pc80/mc146818rtc.h> diff --git a/src/superio/winbond/w83627thg/superio.c b/src/superio/winbond/w83627thg/superio.c index 40a232602d..d42f461fa6 100644 --- a/src/superio/winbond/w83627thg/superio.c +++ b/src/superio/winbond/w83627thg/superio.c @@ -25,7 +25,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include "chip.h" diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c index 933bde6cef..f606948920 100644 --- a/src/superio/winbond/w83627uhg/superio.c +++ b/src/superio/winbond/w83627uhg/superio.c @@ -25,7 +25,6 @@ #include <string.h> #include <stdint.h> #include <stdlib.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include "chip.h" diff --git a/src/superio/winbond/w83697hf/superio.c b/src/superio/winbond/w83697hf/superio.c index 8f090d0b66..cdf7ecdd1b 100644 --- a/src/superio/winbond/w83697hf/superio.c +++ b/src/superio/winbond/w83697hf/superio.c @@ -23,7 +23,7 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> +#include <lib.h> #include <uart8250.h> #include <pc80/mc146818rtc.h> #include <stdlib.h> diff --git a/src/superio/winbond/w83977f/superio.c b/src/superio/winbond/w83977f/superio.c index e197b372f2..353d4288c4 100644 --- a/src/superio/winbond/w83977f/superio.c +++ b/src/superio/winbond/w83977f/superio.c @@ -23,7 +23,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> diff --git a/src/superio/winbond/w83977tf/superio.c b/src/superio/winbond/w83977tf/superio.c index 40952d2a4b..eabf080a54 100644 --- a/src/superio/winbond/w83977tf/superio.c +++ b/src/superio/winbond/w83977tf/superio.c @@ -25,7 +25,6 @@ #include <device/pnp.h> #include <console/console.h> #include <string.h> -#include <bitops.h> #include <uart8250.h> #include <pc80/keyboard.h> #include <stdlib.h> |