summaryrefslogtreecommitdiff
path: root/src/vendorcode/amd
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2018-06-28 16:58:52 +0300
committerPatrick Georgi <pgeorgi@google.com>2019-05-21 09:26:21 +0000
commit7f8a57e96ae8a0ad41bc6024c9fa5a0c14282f15 (patch)
treec058796d8a125a9e3d8420a977c48fbc6c6d4441 /src/vendorcode/amd
parent03180212b7295d288bd79c5756d9355c55bd2193 (diff)
downloadcoreboot-7f8a57e96ae8a0ad41bc6024c9fa5a0c14282f15.tar.xz
soc/amd/common: Refactor AmdCreateStruct() use
AmdCreateStruct() and AmdReleaseStruct() are equally bad when it comes to lack of correct function declarations for definitions found in vendorcode binaryPI/AGESA.c. Replace these with calls that go through the common module_dispatch() functions. Change-Id: I611bcbe2a71fb65c8eb759a9dc74cbd9cb74136e Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31486 Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/vendorcode/amd')
-rw-r--r--src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c27
1 files changed, 0 insertions, 27 deletions
diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index e17cedcb64..da89ce8e6d 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -45,30 +45,3 @@ CONST UINT32 ImageSignature = IMAGE_SIGNATURE;
CONST UINT32 ModuleSignature = MODULE_SIGNATURE;
CONST CHAR8 ModuleIdentifier[8] = AGESA_ID;
-/**********************************************************************
- * Interface call: AmdCreateStruct
- **********************************************************************/
-AGESA_STATUS
-AmdCreateStruct (
- IN OUT AMD_INTERFACE_PARAMS *InterfaceParams
- )
-{
- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
- InterfaceParams->StdHeader.Func = AMD_CREATE_STRUCT;
- if (!Dispatcher) return AGESA_UNSUPPORTED;
- return Dispatcher(InterfaceParams);
-}
-
-/**********************************************************************
- * Interface call: AmdReleaseStruct
- **********************************************************************/
-AGESA_STATUS
-AmdReleaseStruct (
- IN OUT AMD_INTERFACE_PARAMS *InterfaceParams
- )
-{
- MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
- InterfaceParams->StdHeader.Func = AMD_RELEASE_STRUCT;
- if (!Dispatcher) return AGESA_UNSUPPORTED;
- return Dispatcher(InterfaceParams);
-}