summaryrefslogtreecommitdiff
path: root/src/vendorcode/amd
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-07-09 00:25:58 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-07-09 23:20:04 +0000
commit5eb75fe55011bc80d9e9ef6dea801830146274ce (patch)
treeeb90ec8a49445fb05564b1f9dab32332b691f6a5 /src/vendorcode/amd
parent357cc6552ab6f0202c329e9565b278366e2494b8 (diff)
downloadcoreboot-5eb75fe55011bc80d9e9ef6dea801830146274ce.tar.xz
vc/amd/fsp/picasso: add comment on logical lane numbers in descriptor
The expected lane numbers in the fsp_pcie_descriptor struct are the logical and not the physical ones. Change-Id: I14166bbd397a9e5f5c5370717e039b9e71cbdb07 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43311 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Raul Rangel <rrangel@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/vendorcode/amd')
-rw-r--r--src/vendorcode/amd/fsp/picasso/platform_descriptors.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
index cae5d45bd8..9765ea6f2e 100644
--- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
+++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
@@ -110,6 +110,7 @@ typedef struct __packed {
} fsp_ddi_descriptor;
/* Picasso PCIe Descriptor: used for assigning lanes, bifurcation and other settings */
+/* Beware that the lane numbers in here are the logical and not the physical lane numbers! */
typedef struct __packed {
uint8_t engine_type;
uint8_t start_lane; // Start lane of the pci device