summaryrefslogtreecommitdiff
path: root/src/vendorcode
diff options
context:
space:
mode:
authorJes Klinke <jbk@google.com>2020-10-14 13:24:32 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-10-19 07:03:37 +0000
commit5c80519466863ae7b8579f1edb90829f7f9ee03d (patch)
tree27136cf23aa6d1f844b26dbc2a2958cbeebf16f9 /src/vendorcode
parentd5faa90df50c820ed3b79d4a5e479767efd73287 (diff)
downloadcoreboot-5c80519466863ae7b8579f1edb90829f7f9ee03d.tar.xz
volteer+vendorcode: Retrieve Cr50 version only via SPI
No recent Chromebooks have used I2C for TPM communication, and as a result, a bug has crept in. The ability to extract Cr50 firmware string is only supported via SPI, yet code in mainboard and vendorcode attempt to do so unconditionally. This CL makes it such that the code also compiles for future designs using I2C. (Whether we want to enhance the I2C protocol to be able to provide the version string, and then implement the support is a separate question.) This effort is prompted by the desire to use reworked Volteer EVT devices for validating the new Ti50/Dauntless TPM. Dauntless will primarily be using I2C in upcoming designs. BRANCH=volteer TEST=util/abuild/abuild -t GOOGLE_VOLTEER -c max -x Change-Id: Ida1d732e486b19bdff6d95062a3ac1a7c4b58b45 Signed-off-by: jbk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/46436 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Caveh Jalali <caveh@chromium.org>
Diffstat (limited to 'src/vendorcode')
-rw-r--r--src/vendorcode/google/chromeos/cse_board_reset.c33
1 files changed, 18 insertions, 15 deletions
diff --git a/src/vendorcode/google/chromeos/cse_board_reset.c b/src/vendorcode/google/chromeos/cse_board_reset.c
index 65e09aeedb..0b213a66de 100644
--- a/src/vendorcode/google/chromeos/cse_board_reset.c
+++ b/src/vendorcode/google/chromeos/cse_board_reset.c
@@ -16,23 +16,26 @@ void cse_board_reset(void)
int ret;
struct cr50_firmware_version version;
- /* Initialize TPM and get the cr50 firmware version. */
- ret = tlcl_lib_init();
- if (ret != VB2_SUCCESS) {
- printk(BIOS_ERR, "tlcl_lib_init() failed: 0x%x\n", ret);
- return;
- }
+ if (CONFIG(MAINBOARD_HAS_SPI_TPM_CR50)) {
+ /* Initialize TPM and get the cr50 firmware version. */
+ ret = tlcl_lib_init();
+ if (ret != VB2_SUCCESS) {
+ printk(BIOS_ERR, "tlcl_lib_init() failed: 0x%x\n", ret);
+ return;
+ }
- cr50_get_firmware_version(&version);
+ cr50_get_firmware_version(&version);
- /*
- * Cr50 firmware versions 0.[3|4].20 or newer support strap config 0xe where PLTRST from
- * AP is connected to cr50's PLTRST# signal. So return immediately and trigger a
- * global reset.
- */
- if (version.epoch != 0 || version.major > 4 ||
- (version.major >= 3 && version.minor >= 20))
- return;
+ /*
+ * Cr50 firmware versions 0.[3|4].20 or newer support strap
+ * config 0xe where PLTRST from AP is connected to cr50's
+ * PLTRST# signal. So return immediately and trigger a global
+ * reset.
+ */
+ if (version.epoch != 0 || version.major > 4 ||
+ (version.major >= 3 && version.minor >= 20))
+ return;
+ }
printk(BIOS_INFO, "Initiating request to EC to trigger cold reset\n");
/*