summaryrefslogtreecommitdiff
path: root/src/vendorcode
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2019-03-07 22:24:43 +0800
committerDuncan Laurie <dlaurie@chromium.org>2019-03-11 17:20:06 +0000
commit8d8ceade60c09270731026d6778e521d159376b8 (patch)
tree2e030632f912552d92908e2b803545c3d697f133 /src/vendorcode
parentd9a5779a0e2dbe52ca22593da78c32a8b2d7d29e (diff)
downloadcoreboot-8d8ceade60c09270731026d6778e521d159376b8.tar.xz
vendorcode/google/chromeos: Fix AMAC return type
The r8152 kernel driver is expecting the AMAC() method to return a raw buffer, not a string. To fix this simply remove the ToString() in the return statement that was converting the buffer to a string. BUG=b:123925776 Change-Id: I7cd4244a1ccc7397d5969b817a52ea48867b4d17 Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31807 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/vendorcode')
-rw-r--r--src/vendorcode/google/chromeos/acpi/amac.asl4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/vendorcode/google/chromeos/acpi/amac.asl b/src/vendorcode/google/chromeos/acpi/amac.asl
index 838506abcb..51159f5124 100644
--- a/src/vendorcode/google/chromeos/acpi/amac.asl
+++ b/src/vendorcode/google/chromeos/acpi/amac.asl
@@ -19,7 +19,7 @@
* passthru feature which can result in the dock ethernet port using the
* same MAC address that is assigned to the internal NIC. This is done
* by calling an ACPI method at \_SB.AMAC() which returns a formatted
- * string containing the MAC address for the dock to use.
+ * string (as a buffer) containing the MAC address for the dock to use.
*
* The Linux kernel implementation can be found at
* drivers/net/usb/r8152.c:vendor_mac_passthru_addr_read()
@@ -80,6 +80,6 @@ Scope (\_SB)
}
Printf ("AMAC = %o", ToString (Local2))
- Return (ToString (Local2))
+ Return (Local2)
}
}