diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-05-21 00:06:15 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-05-26 11:35:40 +0000 |
| commit | f689d2ee19b25154b0f84fdff1cc2aaa337c4bab (patch) | |
| tree | a5ba27bc0998dbc52ddde88dd63578e11e482dc3 /src/vendorcode | |
| parent | 66ee42daba635a0748262092b28a3ee87bbfd573 (diff) | |
| download | coreboot-f689d2ee19b25154b0f84fdff1cc2aaa337c4bab.tar.xz | |
AGESA f14/f15tn/f16kb: Factor out AGESA_PACKAGE_STRING
We use the same value everywhere, so factor it out. Note that the field
where this value ends up in was doubled in size for AGESA fam16kb, but
we did not update the definition to fill in the additional space. We are
not changing it in this commit so as to preserve binary reproducibility.
In any case, add a FIXME explaining why this value may not be correct.
TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.
Change-Id: Ied118d534ee1e9728db843944d1e042760b4f32c
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41590
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Mike Banon <mikebdp2@gmail.com>
Reviewed-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Diffstat (limited to 'src/vendorcode')
| -rw-r--r-- | src/vendorcode/amd/agesa/f14/AGESA.h | 6 | ||||
| -rw-r--r-- | src/vendorcode/amd/agesa/f15tn/AGESA.h | 6 | ||||
| -rw-r--r-- | src/vendorcode/amd/agesa/f16kb/AGESA.h | 8 |
3 files changed, 20 insertions, 0 deletions
diff --git a/src/vendorcode/amd/agesa/f14/AGESA.h b/src/vendorcode/amd/agesa/f14/AGESA.h index 9bf9207789..6d4cd7bee6 100644 --- a/src/vendorcode/amd/agesa/f14/AGESA.h +++ b/src/vendorcode/amd/agesa/f14/AGESA.h @@ -47,6 +47,12 @@ #ifndef _AGESA_H_ #define _AGESA_H_ +/* + * This is the delivery package title. + * This string MUST be exactly 8 characters long. + */ +#define AGESA_PACKAGE_STRING {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'} + #include "Porting.h" #include "AMD.h" diff --git a/src/vendorcode/amd/agesa/f15tn/AGESA.h b/src/vendorcode/amd/agesa/f15tn/AGESA.h index ce3e857490..e03cdc72f6 100644 --- a/src/vendorcode/amd/agesa/f15tn/AGESA.h +++ b/src/vendorcode/amd/agesa/f15tn/AGESA.h @@ -44,6 +44,12 @@ #ifndef _AGESA_H_ #define _AGESA_H_ +/* + * This is the delivery package title. + * This string MUST be exactly 8 characters long. + */ +#define AGESA_PACKAGE_STRING {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'} + #include "Porting.h" #include "AMD.h" diff --git a/src/vendorcode/amd/agesa/f16kb/AGESA.h b/src/vendorcode/amd/agesa/f16kb/AGESA.h index b9b4354d26..7a7d185f23 100644 --- a/src/vendorcode/amd/agesa/f16kb/AGESA.h +++ b/src/vendorcode/amd/agesa/f16kb/AGESA.h @@ -44,6 +44,14 @@ #ifndef _AGESA_H_ #define _AGESA_H_ +/* + * This is the delivery package title. + * This string MUST be exactly 16 characters long. + * + * FIXME: AMD_CODE_HEADER for this platform expects 16 characters, but there's only 8 here. + */ +#define AGESA_PACKAGE_STRING {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'} + #include "Porting.h" #include "AMD.h" |