summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@amd.corp-partner.google.com>2018-04-19 09:13:19 -0700
committerMartin Roth <martinroth@google.com>2018-04-26 22:00:56 +0000
commit2d72a170588efdf35583fdcd03024acc80a983f0 (patch)
treed98f2132fcee563ff9afe492c666e834078c8647 /src
parentbc8762eaef571da9f4681d09a8ec6d2a501a8115 (diff)
downloadcoreboot-2d72a170588efdf35583fdcd03024acc80a983f0.tar.xz
soc/amd/common/block/include/amdblocks/psp.h: Replace todo message
It was decided to not add the buffers definitions, so the todo message is obsolete. Replace it with minimum instructions about when a new buffer will be needed. It was also noticed a typo in one command. MBOX_BIOS_CMD_C3_DATA_INFO is about S3 transition, so it should be called MBOX_BIOS_CMD_S3_DATA_INFO. BUG=b:77940747 TEST=None. Change-Id: I6143d7e85476061395962b95ad8864ac32a1d4a3 Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/25740 Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/amd/common/block/include/amdblocks/psp.h13
1 files changed, 9 insertions, 4 deletions
diff --git a/src/soc/amd/common/block/include/amdblocks/psp.h b/src/soc/amd/common/block/include/amdblocks/psp.h
index 4c9878a53e..f16bb44e47 100644
--- a/src/soc/amd/common/block/include/amdblocks/psp.h
+++ b/src/soc/amd/common/block/include/amdblocks/psp.h
@@ -29,7 +29,7 @@
#define MBOX_BIOS_CMD_PSP_QUERY 0x05
#define MBOX_BIOS_CMD_BOOT_DONE 0x06
#define MBOX_BIOS_CMD_CLEAR_S3_STS 0x07
-#define MBOX_BIOS_CMD_C3_DATA_INFO 0x08
+#define MBOX_BIOS_CMD_S3_DATA_INFO 0x08
#define MBOX_BIOS_CMD_NOP 0x09
#define MBOX_BIOS_CMD_SMU_FW 0x19
#define MBOX_BIOS_CMD_SMU_FW2 0x1a
@@ -64,13 +64,18 @@ struct mbox_buffer_header {
u32 status; /* command status, filled by PSP if applicable */
} __packed;
-/* command-specific buffer definitions: see NDA document #54267
- * todo: create new definitions here for additional c2p_mbox_command commands
+/*
+ * command-specific buffer definitions: see NDA document #54267
+ * The following commands need a buffer definition if they are to be used.
+ * All other commands will work with the default buffer.
+ * MBOX_BIOS_CMD_SMM_INFO MBOX_BIOS_CMD_PSP_QUERY
+ * MBOX_BIOS_CMD_SX_INFO MBOX_BIOS_CMD_S3_DATA_INFO
+ * MBOX_BIOS_CMD_RSM_INFO
*/
struct mbox_default_buffer { /* command-response buffer unused by command */
struct mbox_buffer_header header;
-} __attribute__((packed,aligned(32)));
+} __attribute__((packed, aligned(32)));
/* send_psp_command() error codes */
#define PSPSTS_SUCCESS 0