summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2017-01-11 10:10:17 -0700
committerNico Huber <nico.h@gmx.de>2017-01-12 18:51:27 +0100
commit3e3b858888d735b45c2868fc50f6de53ca0f868a (patch)
tree1a2fc617f139394b81c97ac196893d3eb269c88d /src
parentf34ca46fa65e86e1b5706ab6dbce4c4e5c5f3323 (diff)
downloadcoreboot-3e3b858888d735b45c2868fc50f6de53ca0f868a.tar.xz
sb/intel/ibexpeak: Update debug code to match other chips
Other chips dump tco_status here if it wasn't handled, which makes sense. tco_sts can't be zero here, because the call would have already returned if it were. Also, dump_tco_status wouldn't print anything if tco_sts were zero. This will still only print the debug information if DEBUG_SMI is enabled in Kconfig, so in general, this change won't have much of an effect on anything. Found-by: Coverity Scan #1229598 Change-Id: Id2c69a16817ba18dfa051f514138fbc04a2f7bee Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/18101 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src')
-rw-r--r--src/southbridge/intel/ibexpeak/smihandler.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c
index ec91bdf3fc..a0b963ea3d 100644
--- a/src/southbridge/intel/ibexpeak/smihandler.c
+++ b/src/southbridge/intel/ibexpeak/smihandler.c
@@ -709,7 +709,7 @@ static void southbridge_smi_tco(void)
} else if (tco_sts & (1 << 3)) { /* TIMEOUT */
/* Handle TCO timeout */
printk(BIOS_DEBUG, "TCO Timeout.\n");
- } else if (!tco_sts) {
+ } else {
dump_tco_status(tco_sts);
}
}