summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-10-09 23:24:31 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-10-19 06:48:10 +0000
commit42aa2cb94ab0b7fefc8204fcf128f6953af00b9a (patch)
tree56041c28cc05540cdb5d44eff058b15a3f26ab66 /src
parent965439be12f8808a47fad3611f6a75d3d2870004 (diff)
downloadcoreboot-42aa2cb94ab0b7fefc8204fcf128f6953af00b9a.tar.xz
mb/purism/librem_skl: Clean up FSP-M RCOMP settings
There's no need to use static functions to fill these settings in. Also, add missing include for <stdint.h> and initialize `mem_cfg` in one line. Change-Id: I82b0997846d4ec40cf9b1a8ebfb1e881b194e078 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46252 Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Felix Singer <felixsinger@posteo.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/purism/librem_skl/romstage.c27
1 files changed, 10 insertions, 17 deletions
diff --git a/src/mainboard/purism/librem_skl/romstage.c b/src/mainboard/purism/librem_skl/romstage.c
index 4982836c66..1c907716c4 100644
--- a/src/mainboard/purism/librem_skl/romstage.c
+++ b/src/mainboard/purism/librem_skl/romstage.c
@@ -3,37 +3,30 @@
#include <assert.h>
#include <soc/romstage.h>
#include <spd_bin.h>
+#include <stdint.h>
#include <string.h>
-static void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
+void mainboard_memory_init_params(FSPM_UPD *mupd)
{
- /* Rcomp resistor */
- const u16 RcompResistor[3] = { 121, 81, 100 };
- memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor));
-}
+ const u16 rcomp_resistors[3] = { 121, 81, 100 };
-static void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
-{
- /* Rcomp target */
- const u16 RcompTarget[5] = { 100, 40, 20, 20, 26 };
- memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
-}
+ const u16 rcomp_targets[5] = { 100, 40, 20, 20, 26 };
+
+ FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
-void mainboard_memory_init_params(FSPM_UPD *mupd)
-{
- FSP_M_CONFIG *mem_cfg;
struct spd_block blk = {
.addr_map = { 0x50 },
};
- mem_cfg = &mupd->FspmConfig;
+ assert(sizeof(mem_cfg->RcompResistor) == sizeof(rcomp_resistors));
+ assert(sizeof(mem_cfg->RcompTarget) == sizeof(rcomp_targets));
get_spd_smbus(&blk);
dump_spd_info(&blk);
assert(blk.spd_array[0][0] != 0);
- mainboard_fill_rcomp_res_data(&mem_cfg->RcompResistor);
- mainboard_fill_rcomp_strength_data(&mem_cfg->RcompTarget);
+ memcpy(mem_cfg->RcompResistor, rcomp_resistors, sizeof(mem_cfg->RcompResistor));
+ memcpy(mem_cfg->RcompTarget, rcomp_targets, sizeof(mem_cfg->RcompTarget));
mem_cfg->DqPinsInterleaved = TRUE;
mem_cfg->MemorySpdDataLen = blk.len;