summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAndrew Wu <arw@dmp.com.tw>2013-08-02 14:45:03 +0800
committerAnton Kochkov <anton.kochkov@gmail.com>2013-08-13 10:11:18 +0200
commit9361daf7fdaa6a4fa81c06e4cdfb7b42b2915051 (patch)
tree749b1836d8e8e0331af087a69c82d760633126fe /src
parent3be80cce290e3ff2da6abc30addab79f5a5ffa07 (diff)
downloadcoreboot-9361daf7fdaa6a4fa81c06e4cdfb7b42b2915051.tar.xz
Fix some wait_for_valid functions return value from 1 to -1.
codec_init expects wait_for_valid returns -1 for timeout, not 1. Change-Id: I0f2a3ebb1934d0adaf13765434526bbc9efca9a3 Signed-off-by: Andrew Wu <arw@dmp.com.tw> Reviewed-on: http://review.coreboot.org/3843 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martin.roth@se-eng.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/southbridge/amd/sb600/hda.c2
-rw-r--r--src/southbridge/amd/sb700/hda.c2
-rw-r--r--src/southbridge/amd/sb800/hda.c2
-rw-r--r--src/southbridge/intel/sch/audio.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/southbridge/amd/sb600/hda.c b/src/southbridge/amd/sb600/hda.c
index 711d84b39b..c65f324832 100644
--- a/src/southbridge/amd/sb600/hda.c
+++ b/src/southbridge/amd/sb600/hda.c
@@ -208,7 +208,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/amd/sb700/hda.c b/src/southbridge/amd/sb700/hda.c
index 48e472d78a..61cc5859d8 100644
--- a/src/southbridge/amd/sb700/hda.c
+++ b/src/southbridge/amd/sb700/hda.c
@@ -130,7 +130,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/amd/sb800/hda.c b/src/southbridge/amd/sb800/hda.c
index c43e9490f0..ad8f80f0d8 100644
--- a/src/southbridge/amd/sb800/hda.c
+++ b/src/southbridge/amd/sb800/hda.c
@@ -132,7 +132,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(u32 base, int addr)
diff --git a/src/southbridge/intel/sch/audio.c b/src/southbridge/intel/sch/audio.c
index 4cb7af2c52..9c7793780a 100644
--- a/src/southbridge/intel/sch/audio.c
+++ b/src/southbridge/intel/sch/audio.c
@@ -187,7 +187,7 @@ static int wait_for_valid(u32 base)
udelay(1);
}
- return 1;
+ return -1;
}
static void codec_init(struct device *dev, u32 base, int addr)