diff options
| author | Marc Jones <marcj303@gmail.com> | 2017-10-24 15:28:24 -0600 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-10-27 16:58:45 +0000 |
| commit | bb59f67ee8aa91eed6cc30daec3fa08d5b651f81 (patch) | |
| tree | 9173116d0fe6344e35812debbadab6e0c5390378 /src | |
| parent | 95b61752dbb56b9a7a2da439c5d21e30643661ef (diff) | |
| download | coreboot-bb59f67ee8aa91eed6cc30daec3fa08d5b651f81.tar.xz | |
soc/amd/common: Remove agesa_LateRunApTask() callback
agesa_LateRunApTask() is not a callback, but a AGESA call. This is a mistake
in the AGESA spec and the function is in the wrong section.
bug=b:66690176, b:67210418
branch=none
test=none
Change-Id: I900e7db13a58e73a7b054e06088bc77c89445876
Signed-off-by: Marc Jones <marcj303@gmail.com>
Reviewed-on: https://review.coreboot.org/22150
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/common/BiosCallOuts.h | 1 | ||||
| -rw-r--r-- | src/soc/amd/common/def_callouts.c | 10 |
2 files changed, 0 insertions, 11 deletions
diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h index ef853fa52b..1f1ebf7dec 100644 --- a/src/soc/amd/common/BiosCallOuts.h +++ b/src/soc/amd/common/BiosCallOuts.h @@ -50,7 +50,6 @@ AGESA_STATUS agesa_GfxGetVbiosImage(UINT32 Func, UINTN FchData, AGESA_STATUS agesa_ReadSpd(UINT32 Func, UINTN Data, VOID *ConfigPtr); AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr); -AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr); AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data, VOID *ConfigPtr); AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data, diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c index 6e46f69ec0..fd3b5e9131 100644 --- a/src/soc/amd/common/def_callouts.c +++ b/src/soc/amd/common/def_callouts.c @@ -39,7 +39,6 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] = { { AGESA_READ_SPD, agesa_ReadSpd }, { AGESA_RUNFUNC_ONAP, agesa_RunFuncOnAp }, { AGESA_RUNFUNC_ON_ALL_APS, agesa_RunFcnOnAllAps }, - { AMD_LATE_RUN_AP_TASK, agesa_LateRunApTask }, { AGESA_GNB_PCIE_SLOT_RESET, agesa_PcieSlotResetControl }, { AGESA_WAIT_FOR_ALL_APS, agesa_WaitForAllApsFinished }, { AGESA_IDLE_AN_AP, agesa_IdleAnAp }, @@ -163,15 +162,6 @@ AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr) return Status; } -AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr) -{ - printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); - AGESA_STATUS Status = AGESA_UNSUPPORTED; - - return Status; -} - - AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data, VOID *ConfigPtr) { |