summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorYouness Alaoui <youness.alaoui@puri.sm>2017-09-29 16:40:38 -0400
committerMartin Roth <martinroth@google.com>2017-10-22 01:48:59 +0000
commite0603e318389986a4f388bf8d3f7bca6d53d7956 (patch)
treef752fb335781fc0cbb75dce1aaa1fb5e7f31f0cd /src
parent6370e7dfc1d0b3436717333b08dd6955f51fb935 (diff)
downloadcoreboot-e0603e318389986a4f388bf8d3f7bca6d53d7956.tar.xz
skylake/me: Add debug output of HFST registers
The ME status is the interpretation of the status registers, but having the actual status registers printed is important and it doesn't hurt to show them. Change-Id: I6ef3401b36fedfa8aed14f4a62bdbec3d8c6d446 Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm> Reviewed-on: https://review.coreboot.org/21960 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/skylake/include/soc/me.h2
-rw-r--r--src/soc/intel/skylake/me.c12
2 files changed, 14 insertions, 0 deletions
diff --git a/src/soc/intel/skylake/include/soc/me.h b/src/soc/intel/skylake/include/soc/me.h
index e88711ddf3..b94e0ef620 100644
--- a/src/soc/intel/skylake/include/soc/me.h
+++ b/src/soc/intel/skylake/include/soc/me.h
@@ -188,6 +188,8 @@ union me_hfs3 {
} __packed fields;
};
+#define PCI_ME_HFSTS4 0x64
+#define PCI_ME_HFSTS5 0x68
#define PCI_ME_HFSTS6 0x6c
#define ME_HFS6_FPF_NOT_COMMITTED 0x0
#define ME_HFS6_FPF_ERROR 0x2
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index 1a6dcddd90..f4df831445 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -232,6 +232,18 @@ void intel_me_status(void)
hfs3.data = me_read_config32(PCI_ME_HFSTS3);
hfs6.data = me_read_config32(PCI_ME_HFSTS6);
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 1 : 0x%08X\n",
+ hfs.data);
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 2 : 0x%08X\n",
+ hfs2.data);
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 3 : 0x%08X\n",
+ hfs3.data);
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 4 : 0x%08X\n",
+ me_read_config32(PCI_ME_HFSTS4));
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 5 : 0x%08X\n",
+ me_read_config32(PCI_ME_HFSTS5));
+ printk(BIOS_DEBUG, "ME: Host Firmware Status Register 6 : 0x%08X\n",
+ hfs6.data);
/* Check Current States */
printk(BIOS_DEBUG, "ME: FW Partition Table : %s\n",
hfs.fields.fpt_bad ? "BAD" : "OK");