summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLijian Zhao <lijian.zhao@intel.com>2019-04-19 17:36:46 -0700
committerDuncan Laurie <dlaurie@chromium.org>2019-05-10 17:00:59 +0000
commitf36fcdf2ab6a9956ac60012404e0edf1d6653fac (patch)
treeaf7aa95333beb0ba0e30f6ba78fd4ca716d31f79 /src
parent9646cfe989a096372a717d8ef16ce5096d1b2708 (diff)
downloadcoreboot-f36fcdf2ab6a9956ac60012404e0edf1d6653fac.tar.xz
mb/google/sarien: Fix s5 touchscreen power leakage
Leakage power is observed from TOUCH_SCREEN_PD# (GPP_E7 which is connected to RESET pin of Wacom controller) during S5. To avoid leakage power, GPP_E7 needs to be turned off before S5 entry. BUG=b:129899315 TEST=Measure leakage power in S5 from both Arcada and Sarien Signed-off-by: Lijian Zhao <lijian.zhao@intel.com> Change-Id: Ie4229477b7149c0a75f4a8c6c7c453a37cc1c78c Reviewed-on: https://review.coreboot.org/c/coreboot/+/32367 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Roy Mingi Park <roy.mingi.park@intel.com> Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl4
-rw-r--r--src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl4
2 files changed, 8 insertions, 0 deletions
diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl
index bc03696048..41121d28fe 100644
--- a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl
+++ b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl
@@ -14,6 +14,7 @@
*/
#define CAM_EN GPP_B11 /* Active low */
+#define TS_PD GPP_E7
/* Method called from LPIT prior to enter s0ix state */
Method (MS0X, 1)
@@ -31,6 +32,9 @@ Method (MS0X, 1)
Method (MPTS, 1)
{
\_SB.PCI0.LPCB.EC0.PTS (Arg0)
+
+ /* Clear touch screen pd pin to avoid leakage */
+ \_SB.PCI0.CTXS (TS_PD)
}
/* Method called from _WAK prior to wakeup */
diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl
index bc03696048..41121d28fe 100644
--- a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl
+++ b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl
@@ -14,6 +14,7 @@
*/
#define CAM_EN GPP_B11 /* Active low */
+#define TS_PD GPP_E7
/* Method called from LPIT prior to enter s0ix state */
Method (MS0X, 1)
@@ -31,6 +32,9 @@ Method (MS0X, 1)
Method (MPTS, 1)
{
\_SB.PCI0.LPCB.EC0.PTS (Arg0)
+
+ /* Clear touch screen pd pin to avoid leakage */
+ \_SB.PCI0.CTXS (TS_PD)
}
/* Method called from _WAK prior to wakeup */