diff options
| author | Hung-Te Lin <hungte@chromium.org> | 2013-04-30 16:11:32 +0800 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2013-05-01 07:43:31 +0200 |
| commit | 0004c0deec8d60cf952426746e2d9519f6de38d6 (patch) | |
| tree | b14b190c540bbc1a3465c69fa752299442cbac14 /src | |
| parent | 8fc41e1b84301e76921730caa4e6b8e8bf27cc35 (diff) | |
| download | coreboot-0004c0deec8d60cf952426746e2d9519f6de38d6.tar.xz | |
Google/Snow: Remove duplicated SPI1 initialization in bootblock.
The firmware media source (SPI1) is already initialized by Exynos iROM.
There is no need to do it again.
Verified by building and booting Google/Snow successfully.
Change-Id: I89390506aa825397c0d7e52ad7503f1cb808f7db
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/3147
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/google/snow/bootblock.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c index 1746290b97..4a7894641c 100644 --- a/src/mainboard/google/snow/bootblock.c +++ b/src/mainboard/google/snow/bootblock.c @@ -40,8 +40,13 @@ void bootblock_mainboard_init(void) * We want to do this as early as we can. */ timer_start(); - exynos_pinmux_config(PERIPH_ID_SPI1, PINMUX_FLAG_NONE); break; } + + /* For most ARM systems, we have to initialize firmware media source + * (ex, SPI, SD/MMC, or eMMC) now; but for Exynos platform, that is + * already handled by iROM so there's no need to setup again. + */ + console_init(); } |