summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-08-04 14:33:58 -0500
committerMartin Roth <martinroth@google.com>2016-08-08 18:34:17 +0200
commit258a3507de825129f5e2a0eb2a31ef3262b1758b (patch)
treeba3f45a89f23490fce82e50ba3dda21a7db9b145 /src
parenta7b97510aeb1652fd0006c9b2d10df6568f37e2e (diff)
downloadcoreboot-258a3507de825129f5e2a0eb2a31ef3262b1758b.tar.xz
commonlib/region: make buffer argument const for writeat
The buffer for writeat() should be marked as const as the contents won't be manipulated within the call. BUG=chrome-os-partner:55932 Change-Id: I968570c1cf80f918a07b97af625a56f11b5889c1 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/16084 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/commonlib/include/commonlib/region.h6
-rw-r--r--src/commonlib/region.c8
2 files changed, 7 insertions, 7 deletions
diff --git a/src/commonlib/include/commonlib/region.h b/src/commonlib/include/commonlib/region.h
index ffc507beae..bc3ded1d0a 100644
--- a/src/commonlib/include/commonlib/region.h
+++ b/src/commonlib/include/commonlib/region.h
@@ -52,8 +52,8 @@ ssize_t rdev_readat(const struct region_device *rd, void *b, size_t offset,
* Returns < 0 on error otherwise returns size of data wrote at provided
* offset from the buffer passed.
*/
-ssize_t rdev_writeat(const struct region_device *rd, void *b, size_t offset,
- size_t size);
+ssize_t rdev_writeat(const struct region_device *rd, const void *b,
+ size_t offset, size_t size);
/*
* Returns < 0 on error otherwise returns size of data erased.
@@ -81,7 +81,7 @@ struct region_device_ops {
void *(*mmap)(const struct region_device *, size_t, size_t);
int (*munmap)(const struct region_device *, void *);
ssize_t (*readat)(const struct region_device *, void *, size_t, size_t);
- ssize_t (*writeat)(const struct region_device *, void *, size_t,
+ ssize_t (*writeat)(const struct region_device *, const void *, size_t,
size_t);
ssize_t (*eraseat)(const struct region_device *, size_t, size_t);
};
diff --git a/src/commonlib/region.c b/src/commonlib/region.c
index d7bea03ae9..838107f312 100644
--- a/src/commonlib/region.c
+++ b/src/commonlib/region.c
@@ -103,8 +103,8 @@ ssize_t rdev_readat(const struct region_device *rd, void *b, size_t offset,
return rdev->ops->readat(rdev, b, req.offset, req.size);
}
-ssize_t rdev_writeat(const struct region_device *rd, void *b, size_t offset,
- size_t size)
+ssize_t rdev_writeat(const struct region_device *rd, const void *b,
+ size_t offset, size_t size)
{
const struct region_device *rdev;
struct region req = {
@@ -257,7 +257,7 @@ static ssize_t mdev_readat(const struct region_device *rd, void *b,
return size;
}
-static ssize_t mdev_writeat(const struct region_device *rd, void *b,
+static ssize_t mdev_writeat(const struct region_device *rd, const void *b,
size_t offset, size_t size)
{
const struct mem_region_device *mdev;
@@ -380,7 +380,7 @@ static ssize_t xlate_readat(const struct region_device *rd, void *b,
return rdev_readat(xldev->access_dev, b, offset, size);
}
-static ssize_t xlate_writeat(const struct region_device *rd, void *b,
+static ssize_t xlate_writeat(const struct region_device *rd, const void *b,
size_t offset, size_t size)
{
struct region req = {