diff options
| author | Paul Menzel <pmenzel@molgen.mpg.de> | 2017-10-31 17:21:23 +0100 |
|---|---|---|
| committer | Matt DeVillier <matt.devillier@gmail.com> | 2017-11-30 22:50:14 +0000 |
| commit | 88a61bbd00ea2da6c0c0f40219783b207b72643e (patch) | |
| tree | 7579a51b13a2ef67e2a3fbf88b9f42b85be17100 /src | |
| parent | 6ff10789909c86dadd61dadefa7e961990a7b6cf (diff) | |
| download | coreboot-88a61bbd00ea2da6c0c0f40219783b207b72643e.tar.xz | |
nuvoton/nct5572d: Disable mouse controller also during resume
Currently, having a keyboard connected to the PS/2 controller of the
ASRock E350M1, after suspending and resuming the system, the keyboard
does not work anymore. A similar problem is documented in commit
448e3863 (drivers/pc80: Add PS/2 mouse presence detect) [1].
There is no reason to not disable the controller during resume. Also,
that way, the PS2 ASL method does not need to be overriden.
[1] https://review.coreboot.org/13165
TEST=Resume system, and notice PS/2 keyboard works.
Change-Id: I51dc446861120f80bc9ffc4cc54b86e317d99689
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/22287
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src')
| -rw-r--r-- | src/superio/nuvoton/nct5572d/superio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/superio/nuvoton/nct5572d/superio.c b/src/superio/nuvoton/nct5572d/superio.c index 1c0ae38113..12b1c78e3a 100644 --- a/src/superio/nuvoton/nct5572d/superio.c +++ b/src/superio/nuvoton/nct5572d/superio.c @@ -56,7 +56,7 @@ static void nct5572d_init(struct device *dev) mouse_detected = pc_keyboard_init(PROBE_AUX_DEVICE); - if (!mouse_detected && !acpi_is_wakeup_s3()) { + if (!mouse_detected) { printk(BIOS_INFO, "%s: Disable mouse controller.", __func__); pnp_enter_conf_mode_8787(dev); |