summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-11-14 00:33:18 +0100
committerFelix Held <felix-coreboot@felixheld.de>2020-11-20 22:07:56 +0000
commit96a06dd46443754ab2aa07fd3ecacf03d34265e1 (patch)
tree5b966caaac08bc0f007bfb7eb99e1b4809d43574 /src
parentcdd7d18120a1a76df4a9f8d78391c7018013d916 (diff)
downloadcoreboot-96a06dd46443754ab2aa07fd3ecacf03d34265e1.tar.xz
nb/intel/sandybridge: Rename loop variable
The `discover_edges_real` function actually tests a range of values for DQS PI and evaluates how the system responds. Rename the loop variable. Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47606 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/northbridge/intel/sandybridge/raminit_common.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index b67eb564ca..893d6b27de 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -2310,14 +2310,14 @@ int command_training(ramctr_timing *ctrl)
static int find_read_mpr_margin(ramctr_timing *ctrl, int channel, int slotrank, int *edges)
{
- int edge;
+ int dqs_pi;
int stats[NUM_LANES][MAX_EDGE_TIMING + 1];
int lane;
- for (edge = 0; edge <= MAX_EDGE_TIMING; edge++) {
+ for (dqs_pi = 0; dqs_pi <= MAX_EDGE_TIMING; dqs_pi++) {
FOR_ALL_LANES {
- ctrl->timings[channel][slotrank].lanes[lane].rising = edge;
- ctrl->timings[channel][slotrank].lanes[lane].falling = edge;
+ ctrl->timings[channel][slotrank].lanes[lane].rising = dqs_pi;
+ ctrl->timings[channel][slotrank].lanes[lane].falling = dqs_pi;
}
program_timings(ctrl, channel);
@@ -2337,7 +2337,7 @@ static int find_read_mpr_margin(ramctr_timing *ctrl, int channel, int slotrank,
wait_for_iosav(channel);
FOR_ALL_LANES {
- stats[lane][edge] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane));
+ stats[lane][dqs_pi] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane));
}
}