summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@amd.corp-partner.google.com>2018-10-16 13:53:05 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-10-18 12:47:31 +0000
commitbdd272a95161c2743a262015db0c640b657c5a24 (patch)
treece75fd8356834202a8c4d749e9f6dd7563207eae /src
parentd46bb6bdf0ad2be0bbd5d01a7248785e6da11014 (diff)
downloadcoreboot-bdd272a95161c2743a262015db0c640b657c5a24.tar.xz
soc/amd/stoneyridge/southbridge.c: Change comparison order
Comparison should place the constant on the right side. Southbridge.c has 6 instances where the opposite happens. Reverse the order of six comparisons to eliminate checkpatch warnings: WARNING: Comparisons should place the constant on the right side of the test BUG=b:117656929 TEST=Build grunt. Change-Id: I94f17b81f845fa94599f93c0be1144ffcb8e4165 Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/29153 Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/amd/stoneyridge/southbridge.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index b7ddd578d6..33330a8812 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -53,22 +53,22 @@ const static struct stoneyridge_aoac aoac_devs[] = {
static int is_sata_config(void)
{
- return !((CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde)
- || (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde));
+ return !((SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE)
+ || (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE));
}
static inline int sb_sata_enable(void)
{
/* True if IDE or AHCI. */
- return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||
- (CONFIG_STONEYRIDGE_SATA_MODE == SataAhci);
+ return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
+ (SataAhci == CONFIG_STONEYRIDGE_SATA_MODE);
}
static inline int sb_ide_enable(void)
{
/* True if IDE or LEGACY IDE. */
- return (CONFIG_STONEYRIDGE_SATA_MODE == SataNativeIde) ||
- (CONFIG_STONEYRIDGE_SATA_MODE == SataLegacyIde);
+ return (SataNativeIde == CONFIG_STONEYRIDGE_SATA_MODE) ||
+ (SataLegacyIde == CONFIG_STONEYRIDGE_SATA_MODE);
}
void SetFchResetParams(FCH_RESET_INTERFACE *params)