summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTristan Corrick <tristancorrick86@gmail.com>2017-05-10 22:40:41 +1200
committerPatrick Georgi <pgeorgi@google.com>2017-05-11 16:53:25 +0200
commit12e6562289b85a9988048fc731be92966110c622 (patch)
treea6dd4ee3f88830412696daf60b05764af8dc8962 /src
parent267d086a0835f8fae8414cd91350fd19627564dc (diff)
downloadcoreboot-12e6562289b85a9988048fc731be92966110c622.tar.xz
nb/intel/gm45: Fix raminit with mixed raw card types
`cardF[n]` should indicate whether the DIMM in channel n is of raw card type F. However, `cardF[1]` was initialised with the value meant for `cardF[0]`. This patch results in the correct initialisation of `cardF`. Tested on a Lenovo T400 containing two DIMMs: one of raw card type F and the other of raw card type B. Before the patch, the system would not boot. After the patch, the system boots with all of the memory functional. Change-Id: I7409df0b8c67d7efbdadae39dc718c8df7a92552 Signed-off-by: Tristan Corrick <tristancorrick86@gmail.com> Reviewed-on: https://review.coreboot.org/19652 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src')
-rw-r--r--src/northbridge/intel/gm45/raminit_receive_enable_calibration.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
index c5614e1192..7d57a4e84b 100644
--- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
+++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
@@ -211,7 +211,7 @@ static void receive_enable_calibration(const timings_t *const timings,
const int cardF[] = {
dimms[0].card_type == 0xf,
- dimms[0].card_type == 0xf,
+ dimms[1].card_type == 0xf,
};
const unsigned int t_bound =