summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-07-25 13:49:53 -0600
committerPatrick Georgi <pgeorgi@google.com>2019-08-20 15:16:17 +0000
commit12ef4f2d7173dc73ec802f6175fa05531a46df00 (patch)
treed73dc54ae4fb383071474b379be2b91c7592ce75 /src
parent07841c2a2a930383dfd56d5adc966d0efaafec66 (diff)
downloadcoreboot-12ef4f2d7173dc73ec802f6175fa05531a46df00.tar.xz
mb/asus/kfsn4-dre: Return early if CK804 not found
It probably doesn't make sense to continue if the CK804 isn't found, and doing so would perform uninitialized reads of the busn and io_base arrays anyway, so let's return early. Change-Id: I13c663314496caf51a57da7f27f9ea24e3d7fcbd Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 1370586 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34573 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/asus/kfsn4-dre/romstage.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/mainboard/asus/kfsn4-dre/romstage.c b/src/mainboard/asus/kfsn4-dre/romstage.c
index 7b20243863..22eb1157b9 100644
--- a/src/mainboard/asus/kfsn4-dre/romstage.c
+++ b/src/mainboard/asus/kfsn4-dre/romstage.c
@@ -132,8 +132,10 @@ static void ck804_control(const unsigned int *values, u32 size,
}
}
- if (ck804_num < 1)
+ if (ck804_num < 1) {
printk(BIOS_WARNING, "CK804 not found at device base unit id %02x!\n", bus_unit_id);
+ return;
+ }
ck804_early_set_port(ck804_num, busn, io_base);