summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-07-12 08:02:35 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2019-07-17 04:25:51 +0000
commitf44f331e169622f228d08a3051e9215747cce61f (patch)
tree069c232e9efc07e45079e03d0c73976fe76a2c40 /src
parentb8302110b88c8c6d96a1b8d28ae7bc967b7c9a19 (diff)
downloadcoreboot-f44f331e169622f228d08a3051e9215747cce61f.tar.xz
intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER
The code should probably set SCI routing if built with HAVE_SMI_HANDLER=n. Change-Id: I0ada4b2a16490a15d8036a9425c4f768f7b8f218 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34255 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/fsp_baytrail/gpio.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/soc/intel/fsp_baytrail/gpio.c b/src/soc/intel/fsp_baytrail/gpio.c
index 8d4e090a40..2409eaa541 100644
--- a/src/soc/intel/fsp_baytrail/gpio.c
+++ b/src/soc/intel/fsp_baytrail/gpio.c
@@ -192,6 +192,10 @@ static void setup_gpio_route(const struct soc_gpio_map *sus,
uint32_t route_reg = 0;
int i;
+ /* FIXME: SCI interrupts should be routed regardlessy. */
+ if (!CONFIG(HAVE_SMI_HANDLER))
+ return;
+
for (i = 0; i < 8; i++) {
/* SMI takes precedence and wake_en implies SCI. */
if (sus[i].smi) {
@@ -207,9 +211,7 @@ static void setup_gpio_route(const struct soc_gpio_map *sus,
}
}
-#if CONFIG(HAVE_SMI_HANDLER)
southcluster_smm_save_gpio_route(route_reg);
-#endif
}
static void setup_dirqs(const u8 dirq[GPIO_MAX_DIRQS],