diff options
| author | Paul Menzel <paulepanter@users.sourceforge.net> | 2015-06-07 20:28:17 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-06-09 22:00:53 +0200 |
| commit | db23215039894cf7668cba21c94753a9fcc546a0 (patch) | |
| tree | 9eba19c71c9c1f79ccdf580dd00ff992658874da /src | |
| parent | 946bf935dbfcb9998e14189b3d32c555053d8137 (diff) | |
| download | coreboot-db23215039894cf7668cba21c94753a9fcc546a0.tar.xz | |
device/device.c: Improve output in `init_dev()`
Since commit 05294292 (device tree: track init times) there are two
lines printed for each init() call of a device, when
`HAVE_MONOTONIC_TIMER` is selected.
[…]
CPU_CLUSTER: 0 init 12708 usecs
DOMAIN: 0000 init
DOMAIN: 0000 init 1 usecs
PCI: 00:00.0 init
Northbridge init
PCI: 00:00.0 init 2 usecs
PCI: 00:01.0 init
PCI: 00:01.0 init 1 usecs
PCI: 00:01.1 init
PCI: 00:01.1 init 1 usecs
PCI: 00:11.0 init
PCI: 00:11.0 init 1 usecs
PCI: 00:14.0 init
PCI: 00:14.0 init 1 usecs
PCI: 00:14.3 init
SB800 - Late.c - lpc_init - Start.
RTC Init
RTC: coreboot checksum invalid
SB800 - Late.c - lpc_init - End.
[…]
Improve the output by changing the wording to.
%s init ...\n
init()
%s init finished in %ld usecs\n
Note, that `%s init ... done in %ld usecs` is not possible as the
function `init()` can also print messages.
Change-Id: I7132cd650911dba680f060d6073a5a09c879b24c
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/10455
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/device/device.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/device/device.c b/src/device/device.c index 6bdeae1e0a..a768ff7811 100644 --- a/src/device/device.c +++ b/src/device/device.c @@ -1144,11 +1144,11 @@ static void init_dev(struct device *dev) dev_path(dev->bus->dev), dev->bus->link_num); } - printk(BIOS_DEBUG, "%s init\n", dev_path(dev)); + printk(BIOS_DEBUG, "%s init ...\n", dev_path(dev)); dev->initialized = 1; dev->ops->init(dev); #if CONFIG_HAVE_MONOTONIC_TIMER - printk(BIOS_DEBUG, "%s init %ld usecs\n", dev_path(dev), + printk(BIOS_DEBUG, "%s init finished in %ld usecs\n", dev_path(dev), stopwatch_duration_usecs(&sw)); #endif } |