diff options
| author | Vladimir Serbinenko <phcoder@gmail.com> | 2013-11-26 16:37:45 +0100 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-12-02 22:15:45 +0100 |
| commit | dfc0881272ebb7d865fefbb037f7545b37bf2be3 (patch) | |
| tree | 9a9ea8a4d91ac23352ea463e4213a5b07281ca28 /src | |
| parent | 72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (diff) | |
| download | coreboot-dfc0881272ebb7d865fefbb037f7545b37bf2be3.tar.xz | |
EC H8: remove dependence on IS_X201
Instead define brightness up/down function and gfx device and use
preprocessor magic to glue it together.
Change-Id: I03074ae07b33c1546d229efc3e80606ddbee6300
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/4282
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martin.roth@se-eng.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/ec/lenovo/h8/acpi/ec.asl | 20 | ||||
| -rw-r--r-- | src/mainboard/lenovo/t60/dsdt.asl | 2 | ||||
| -rw-r--r-- | src/mainboard/lenovo/x60/dsdt.asl | 2 |
3 files changed, 8 insertions, 16 deletions
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index df19fb883c..4b3fb12154 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -97,35 +97,23 @@ Device(EC) Notify(^SLPB, 0x80) } -#if IS_ENABLED (CONFIG_BOARD_LENOVO_X201) /* Brightness up GPE */ Method(_Q14, 0, NotSerialized) { - \_SB.PCI0.GFX0.LCD0.INCB() + BRIGHTNESS_UP() } /* Brightness down GPE */ Method(_Q15, 0, NotSerialized) { - \_SB.PCI0.GFX0.LCD0.DECB() + BRIGHTNESS_DOWN() } +#ifdef ACPI_VIDEO_DEVICE /* Next display GPE */ Method(_Q16, 0, NotSerialized) { - Notify (\_SB.PCI0.GFX0, 0x82) - } -#else - /* Brightness up GPE */ - Method(_Q14, 0, NotSerialized) - { - \DSPC.BRTU () - } - - /* Brightness down GPE */ - Method(_Q15, 0, NotSerialized) - { - \DSPC.BRTD() + Notify (ACPI_VIDEO_DEVICE, 0x82) } #endif /* AC status change: present */ diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index 383bb30c35..842dbc3d72 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -20,6 +20,8 @@ */ #define THINKPAD_EC_GPE 28 +#define BRIGHTNESS_UP \DSPC.BRTU +#define BRIGHTNESS_DOWN \DSPC.BRTD DefinitionBlock( "dsdt.aml", diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl index 383bb30c35..842dbc3d72 100644 --- a/src/mainboard/lenovo/x60/dsdt.asl +++ b/src/mainboard/lenovo/x60/dsdt.asl @@ -20,6 +20,8 @@ */ #define THINKPAD_EC_GPE 28 +#define BRIGHTNESS_UP \DSPC.BRTU +#define BRIGHTNESS_DOWN \DSPC.BRTD DefinitionBlock( "dsdt.aml", |