summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-01-16 09:22:22 -0700
committerMartin Roth <martinroth@google.com>2016-01-16 21:03:30 +0100
commit5d6929b1d7066bc7f1963eb2a511cdf734f33f94 (patch)
tree8a86e2c7a9f6549d180fc416d713c2990c389e4e /src
parentc5dfdc5992cf1d9ec6b6e5b4f24a7d2fab85b024 (diff)
downloadcoreboot-5d6929b1d7066bc7f1963eb2a511cdf734f33f94.tar.xz
intel/skylake: Fix uninitialized variable warning
I don't think the warning is valid, because we already verify that num_channels is 2 or 4 as soon as we enter the function. Adding the default case makes the compiler happy. Fixes warning: src/soc/intel/skylake/nhlt/dmic.c: In function 'nhlt_soc_add_dmic_array': src/soc/intel/skylake/nhlt/dmic.c:100:2: error: 'formats' may be used uninitialized in this function [-Werror=maybe-uninitialized] return nhlt_endpoint_add_formats(endp, formats, num_formats); ^ Change-Id: Idc22c8478ff666af8915d780d7553909c3163690 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/13021 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/intel/skylake/nhlt/dmic.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/soc/intel/skylake/nhlt/dmic.c b/src/soc/intel/skylake/nhlt/dmic.c
index 0aadbb20df..6e14891f18 100644
--- a/src/soc/intel/skylake/nhlt/dmic.c
+++ b/src/soc/intel/skylake/nhlt/dmic.c
@@ -90,6 +90,8 @@ int nhlt_soc_add_dmic_array(struct nhlt *nhlt, int num_channels)
num_formats = ARRAY_SIZE(dmic_4ch_cfg);
mic_config.array_type = NHLT_MIC_ARRAY_4CH_L_SHAPED;
break;
+ default:
+ return -1;
}
if (nhlt_endpoint_append_config(endp, &mic_config, sizeof(mic_config)))