summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2017-03-10 14:25:48 -0800
committerPatrick Georgi <pgeorgi@google.com>2017-04-28 06:48:10 +0200
commitd1e3b9b7007d47e51499d0861427f6a6c554f7d6 (patch)
treeb662124ccd348394246fcf8827d32a1af0ef27ef /src
parent97a9df4f77daf3a1b7f519d2235b374c183f8f70 (diff)
downloadcoreboot-d1e3b9b7007d47e51499d0861427f6a6c554f7d6.tar.xz
google/oak: Configure SD card detect pin with a pull-up
SD card detect pins should normally have a pull-up. It seems that for micro-SD cards this doesn't really matter all that much, but for the full-size slots we have on some Oak-derivatives (like Hana) it does. BRANCH=oak BUG=b:35854317 TEST=Booted Hana, confirmed that card detect no longer seemed stuck-on. Booted Elm and confirmed that SD card behavior didn't change. Change-Id: I9b20e0f6fe310e724d191e36ca0a81ab4fe5f593 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: c2781eeef50f52c6f02ee9344274ddf4dcb0a946 Original-Change-Id: I428ac92efb07f94265673b04e0e0dd452649b9fd Original-Signed-off-by: Julius Werner <jwerner@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/452861 Original-Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://review.coreboot.org/19432 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/google/oak/mainboard.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c
index 38311e50f1..327e799499 100644
--- a/src/mainboard/google/oak/mainboard.c
+++ b/src/mainboard/google/oak/mainboard.c
@@ -320,7 +320,7 @@ static void mainboard_init(device_t dev)
mt6391_gpio_output(MT6391_KP_ROW2, 1);
/* Config SD card detection pin */
- gpio_input(PAD_EINT1); /* SD_DET */
+ gpio_input_pullup(PAD_EINT1); /* SD_DET */
configure_audio();