summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2018-10-25 10:37:24 +0200
committerPatrick Georgi <pgeorgi@google.com>2018-11-05 08:56:59 +0000
commit07065edd5e8ccb334f7b865396dd8196be5c76c5 (patch)
treec81c8bb1868257eed8877207c7a7061d90b00ed5 /src
parent407f512cfea4ef84705ffa869fdf332d7e7d842c (diff)
downloadcoreboot-07065edd5e8ccb334f7b865396dd8196be5c76c5.tar.xz
src/mainboard: Remove irrelevant conditional statement
Using a conditional statement to return 0 or 1 depending on a logic value is unnecessarily complex. Change-Id: I449ce2b71b72374de5ec4986f9cc9f91a67856ee Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/29265 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/amd/tilapia_fam10/mainboard.c8
-rw-r--r--src/mainboard/asus/m4a78-em/mainboard.c8
-rw-r--r--src/mainboard/asus/m4a785-m/mainboard.c8
-rw-r--r--src/mainboard/gigabyte/ma785gmt/mainboard.c8
4 files changed, 4 insertions, 28 deletions
diff --git a/src/mainboard/amd/tilapia_fam10/mainboard.c b/src/mainboard/amd/tilapia_fam10/mainboard.c
index 543b77508b..5c052ec829 100644
--- a/src/mainboard/amd/tilapia_fam10/mainboard.c
+++ b/src/mainboard/amd/tilapia_fam10/mainboard.c
@@ -102,13 +102,7 @@ int is_dev3_present(void)
/* read the GPIO68 input status */
word = pci_read_config16(sm_dev, 0x7e);
- if(word & (1 << 10)){
- /*not exist*/
- return 0;
- }else{
- /*exist*/
- return 1;
- }
+ return !(word & (1 << 10));
}
diff --git a/src/mainboard/asus/m4a78-em/mainboard.c b/src/mainboard/asus/m4a78-em/mainboard.c
index b39f9db259..b075c6938e 100644
--- a/src/mainboard/asus/m4a78-em/mainboard.c
+++ b/src/mainboard/asus/m4a78-em/mainboard.c
@@ -94,13 +94,7 @@ int is_dev3_present(void)
/* read the GPIO68 input status */
word = pci_read_config16(sm_dev, 0x7e);
- if(word & (1 << 10)){
- /*not exist*/
- return 0;
- }else{
- /*exist*/
- return 1;
- }
+ return !(word & (1 << 10));
}
diff --git a/src/mainboard/asus/m4a785-m/mainboard.c b/src/mainboard/asus/m4a785-m/mainboard.c
index 0a0eedd859..53c97b8d43 100644
--- a/src/mainboard/asus/m4a785-m/mainboard.c
+++ b/src/mainboard/asus/m4a785-m/mainboard.c
@@ -104,13 +104,7 @@ int is_dev3_present(void)
/* read the GPIO68 input status */
word = pci_read_config16(sm_dev, 0x7e);
- if(word & (1 << 10)){
- /*not exist*/
- return 0;
- }else{
- /*exist*/
- return 1;
- }
+ return !(word & (1 << 10));
}
/*
diff --git a/src/mainboard/gigabyte/ma785gmt/mainboard.c b/src/mainboard/gigabyte/ma785gmt/mainboard.c
index a0e963190d..5949741b45 100644
--- a/src/mainboard/gigabyte/ma785gmt/mainboard.c
+++ b/src/mainboard/gigabyte/ma785gmt/mainboard.c
@@ -102,13 +102,7 @@ int is_dev3_present(void)
/* read the GPIO68 input status */
word = pci_read_config16(sm_dev, 0x7e);
- if(word & (1 << 10)){
- /*not exist*/
- return 0;
- }else{
- /*exist*/
- return 1;
- }
+ return !(word & (1 << 10));
}
/*