summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-09-10 11:12:01 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-09-16 07:14:15 +0000
commit0f651650f38c5166a934b3541f56f32bf4fd93b2 (patch)
treea3c4637c913166f9de57d5f587d9a18b666b2872 /src
parente5aa5ae1ba5bc20af7d4db6e2af3ea9c96900c09 (diff)
downloadcoreboot-0f651650f38c5166a934b3541f56f32bf4fd93b2.tar.xz
drivers/aspeed/common: Reduce severity of `EDID not found` log message
Servers often run headless, so a missing EDID isn't a problem. However, we still need to initialize a framebuffer for the BMC's KVM function. Reduce the log level to BIOS_INFO to avoid confusion. Change-Id: Ice17bf6fdda0ce34e686dbf8f3a1fa92ba869d7c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45234 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src')
-rw-r--r--src/drivers/aspeed/common/ast_mode_corebootfb.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c
index 8418b010f3..b5f794bcb6 100644
--- a/src/drivers/aspeed/common/ast_mode_corebootfb.c
+++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c
@@ -96,7 +96,11 @@ static int ast_select_mode(struct drm_connector *connector,
ast_software_i2c_read(ast, raw);
if (decode_edid(raw, sizeof(raw), edid) != EDID_CONFORMANT) {
- dev_err(dev->pdev, "Failed to decode EDID\n");
+ /*
+ * Servers often run headless, so a missing EDID is not an error.
+ * We still need to initialize a framebuffer for KVM, though.
+ */
+ dev_info(dev->pdev, "Failed to decode EDID\n");
printk(BIOS_DEBUG, "Assuming VGA for KVM\n");
memset(edid, 0, sizeof(*edid));