diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2012-08-02 09:49:11 +0300 |
|---|---|---|
| committer | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2012-08-08 11:42:17 +0200 |
| commit | 4c29d7f27d315ab93c811fb86ba246151dc84da3 (patch) | |
| tree | e914849561d4df2b3da4612485c636db2bdb5936 /src | |
| parent | cf8e4660846eb414d38dc4bb380006806430e902 (diff) | |
| download | coreboot-4c29d7f27d315ab93c811fb86ba246151dc84da3.tar.xz | |
Do not allow modifying memory table directly
Adding ranges directly into coreboot memory table raised issues
as those methods bypassed the MTRR setup. Such regions are now
added as resources, so declare the functions again as static.
Change-Id: If78613da40eabc5c99c49dbe2d6047cb22a71b69
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1415
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src')
| -rw-r--r-- | src/arch/x86/boot/coreboot_table.c | 5 | ||||
| -rw-r--r-- | src/arch/x86/include/arch/coreboot_tables.h | 3 | ||||
| -rw-r--r-- | src/include/boot/tables.h | 3 |
3 files changed, 2 insertions, 9 deletions
diff --git a/src/arch/x86/boot/coreboot_table.c b/src/arch/x86/boot/coreboot_table.c index 9050836fa2..d056837836 100644 --- a/src/arch/x86/boot/coreboot_table.c +++ b/src/arch/x86/boot/coreboot_table.c @@ -338,7 +338,7 @@ static struct lb_forward *lb_forward(struct lb_header *header, struct lb_header } #endif -void lb_memory_range(struct lb_memory *mem, +static void lb_memory_range(struct lb_memory *mem, uint32_t type, uint64_t start, uint64_t size) { int entries; @@ -503,8 +503,7 @@ static void lb_remove_memory_range(struct lb_memory *mem, } } -/* This function is used in mainboard specific code, too */ -void lb_add_memory_range(struct lb_memory *mem, +static void lb_add_memory_range(struct lb_memory *mem, uint32_t type, uint64_t start, uint64_t size) { lb_remove_memory_range(mem, start, size); diff --git a/src/arch/x86/include/arch/coreboot_tables.h b/src/arch/x86/include/arch/coreboot_tables.h index 8fc648b2ca..e9790db17a 100644 --- a/src/arch/x86/include/arch/coreboot_tables.h +++ b/src/arch/x86/include/arch/coreboot_tables.h @@ -8,9 +8,6 @@ unsigned long write_coreboot_table( unsigned long low_table_start, unsigned long low_table_end, unsigned long rom_table_start, unsigned long rom_table_end); -void lb_memory_range(struct lb_memory *mem, - uint32_t type, uint64_t start, uint64_t size); - /* Routines to extract part so the coreboot table or information * from the coreboot table. */ diff --git a/src/include/boot/tables.h b/src/include/boot/tables.h index 4b3f70cf4e..869da26f8c 100644 --- a/src/include/boot/tables.h +++ b/src/include/boot/tables.h @@ -4,9 +4,6 @@ #include <boot/coreboot_tables.h> #include <arch/coreboot_tables.h> -void lb_add_memory_range(struct lb_memory *mem, - uint32_t type, uint64_t start, uint64_t size); - struct lb_memory *write_tables(void); #endif /* BOOT_TABLES_H */ |