summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJonathan Zhang <jonzhang@fb.com>2020-09-21 17:19:21 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-09-28 09:39:11 +0000
commit60d800537bd21ba788efcc6a3b41549e893e3da8 (patch)
tree008dbb57339c2302f6de3d316661576457fd16ed /src
parent1ba42a9ca26b4ecba0164d88e02069a80942c167 (diff)
downloadcoreboot-60d800537bd21ba788efcc6a3b41549e893e3da8.tar.xz
mb/ocp/deltalake: add LPC device entry in ACPI
PCH LPC device is on CSTACK. Add LPC ACPI device entry. Without this change, following error message shows up in target OS boot log: ACPI BIOS Error (bug): Failure looking up [\_SB.PCI0.LPCB], AE_NOT_FOUND (20180105/dswload-211) ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20180105/psobject-252) ACPI Error: AE_NOT_FOUND, (SSDT:COREBOOT) while loading table (20180105/tbxfload-228) ACPI Error: 1 table load failures, 1 successful (20180105/tbxfload-246) Also TPM device is not created. TESTED=Booted DeltaLake DVT, run following command in target OS: [root@dhcp-100-96-192-153 ~]# dmesg | grep tpm [ 7.331890] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1B, rev-id 16) Signed-off-by: Jonathan Zhang <jonzhang@fb.com> Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45592 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marc Jones <marc@marcjonesconsulting.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/ocp/deltalake/dsdt.asl6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/mainboard/ocp/deltalake/dsdt.asl b/src/mainboard/ocp/deltalake/dsdt.asl
index c74b5fecb8..4d784f304e 100644
--- a/src/mainboard/ocp/deltalake/dsdt.asl
+++ b/src/mainboard/ocp/deltalake/dsdt.asl
@@ -20,4 +20,10 @@ DefinitionBlock(
// CPX-SP ACPI tables
#include <soc/intel/xeon_sp/cpx/acpi/uncore.asl>
+
+ // LPC related entries
+ Scope (\_SB.PC00)
+ {
+ #include <soc/intel/common/block/acpi/acpi/lpc.asl>
+ }
}