summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMarshall Dawson <marshalldawson3rd@gmail.com>2019-06-20 14:18:05 -0600
committerMartin Roth <martinroth@google.com>2019-08-09 20:21:16 +0000
commit40bc4857455035c9cb681b993c88e02d25ea2059 (patch)
tree30e9fe8e6406a61815af9e55130f9ea2f37b8ef8 /src
parentc17cc63e481af7f981abbb9e2383b8447a2224d3 (diff)
downloadcoreboot-40bc4857455035c9cb681b993c88e02d25ea2059.tar.xz
soc/amd/picasso: Update machine check support
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com> Change-Id: Iae48a0c3fb2abf2aa3fb78af8d50431c8533f76f Reviewed-on: https://review.coreboot.org/c/coreboot/+/33769 Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
-rw-r--r--src/soc/amd/picasso/mca.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/soc/amd/picasso/mca.c b/src/soc/amd/picasso/mca.c
index 8a875d9206..57fa9c6536 100644
--- a/src/soc/amd/picasso/mca.c
+++ b/src/soc/amd/picasso/mca.c
@@ -97,11 +97,6 @@ static void fill_generic_section(cper_proc_generic_error_section_t *sec,
* which is the best method to report MSR context. As a result, add two
* structures: A "processor generic error" that is parsed, and an IA32/X64 one
* to capture complete information.
- *
- * Future work may attempt to interpret the specific Family 15h error symptoms
- * found in the MCA registers. This data could enhance the reporting of the
- * Processor Generic section and the failing error/check added to the
- * IA32/X64 section.
*/
static void build_bert_mca_error(struct mca_bank *mci)
{
@@ -161,6 +156,7 @@ static const char *const mca_bank_name[] = {
"Floating point unit"
};
+/* Check the Legacy Machine Check Architecture registers */
void check_mca(void)
{
int i;
@@ -173,9 +169,6 @@ void check_mca(void)
if (is_warm_reset()) {
for (i = 0 ; i < num_banks ; i++) {
- if (i == 3) /* Reserved in Family 15h */
- continue;
-
mci.sts = rdmsr(IA32_MC0_STATUS + (i * 4));
if (mci.sts.hi || mci.sts.lo) {
int core = cpuid_ebx(1) >> 24;