summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2017-03-25 22:45:18 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2017-05-30 14:02:23 +0200
commit4c1e41c636c96d3cdf185e660861bb2d7ddd5187 (patch)
tree525c76736e6bbd9bcb7f66220497810891647e62 /src
parent17b1a69c52d5d469f67262d823e2f7219964e3c5 (diff)
downloadcoreboot-4c1e41c636c96d3cdf185e660861bb2d7ddd5187.tar.xz
binaryPI: Move EmptyHeap() call
Specification says to do CAR teardown as part of AmdInitPost(). Move initializing the final AGESA heap storage to AmdInitEnv() so that its work is not lost even if AMD_DISABLE_STACK does invalidation without writeback. Change-Id: Icf0ec74c390e60122d0b312b5f09f46bb930e085 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/19270 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/northbridge/amd/pi/agesawrapper.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/northbridge/amd/pi/agesawrapper.c b/src/northbridge/amd/pi/agesawrapper.c
index d4b9984f81..050d683573 100644
--- a/src/northbridge/amd/pi/agesawrapper.c
+++ b/src/northbridge/amd/pi/agesawrapper.c
@@ -179,8 +179,6 @@ AGESA_STATUS agesawrapper_amdinitpost(void)
);
if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(PostParams->StdHeader.HeapStatus);
AmdReleaseStruct (&AmdParamStruct);
- /* Initialize heap space */
- EmptyHeap();
return status;
}
@@ -191,6 +189,9 @@ AGESA_STATUS agesawrapper_amdinitenv(void)
AMD_INTERFACE_PARAMS AmdParamStruct;
AMD_ENV_PARAMS *EnvParam;
+ /* Initialize heap space */
+ EmptyHeap();
+
LibAmdMemFill (&AmdParamStruct,
0,
sizeof(AMD_INTERFACE_PARAMS),