summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorPaul Menzel <paulepanter@users.sourceforge.net>2014-05-03 16:21:34 +0200
committerPatrick Georgi <patrick@georgi-clan.de>2014-05-05 08:59:05 +0200
commit60ec2ff2f005cc3d361225ad24327dff14c7abf2 (patch)
tree9d70621f067e07cb3c400c0352fc11af0d841ef7 /src
parentf0a59914d884ff74e392fe17c1edbe93557c0efa (diff)
downloadcoreboot-60ec2ff2f005cc3d361225ad24327dff14c7abf2.tar.xz
lib/hexdump: Use `size_t` for length parameter of `hexdump32()`
In the signature of the function `hexdump32()` it does not make sense to represent a length, assumed to be positive, as a signed integer. With this change, it is no longer necessary to cast a pointer to unsigned long when passing it to `hexdump32()`. The same change for the function `hexdump()` was done in commit 3dd0e72d [1]. lib/hexdump: Take const void * and size_t as arguments [1] http://review.coreboot.org/4575 Change-Id: Id97f5daff95f94e862ee8b5be896a6629b125a13 Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-on: http://review.coreboot.org/5646 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Diffstat (limited to 'src')
-rw-r--r--src/include/lib.h2
-rw-r--r--src/lib/hexdump.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/include/lib.h b/src/include/lib.h
index c272eb57b5..8f02004bff 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -52,6 +52,6 @@ extern unsigned char _estack[];
/* Defined in src/lib/hexdump.c */
void hexdump(const void *memory, size_t length);
-void hexdump32(char LEVEL, const void *d, int len);
+void hexdump32(char LEVEL, const void *d, size_t len);
#endif /* __LIB_H__ */
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 44a5aa433f..a15c5cdb11 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -62,7 +62,7 @@ void hexdump(const void *memory, size_t length)
}
}
-void hexdump32(char LEVEL, const void *d, int len)
+void hexdump32(char LEVEL, const void *d, size_t len)
{
int count = 0;