summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-10-25 18:06:58 +0200
committerNico Huber <nico.h@gmx.de>2019-10-27 10:39:28 +0000
commitb759a4f987fe284150334cae184801e2be1f9c53 (patch)
treea99fd4f8a7d9a3913f58610fb623c29834dd5edd /src
parenteafc81514a03174dd0eb7e1c89b2101ccbcaa0cf (diff)
downloadcoreboot-b759a4f987fe284150334cae184801e2be1f9c53.tar.xz
cbmem.h: Align comment with the reality of implementations
cbmem_top() should simply not be called before memory is initialed, in order for the implementation to return something meaningful. Change-Id: I8fe32844af290626a0f91279143fda4d3442680f Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36334 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Michael Niewöhner
Diffstat (limited to 'src')
-rw-r--r--src/include/cbmem.h5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/include/cbmem.h b/src/include/cbmem.h
index f972ba6503..4005fa205a 100644
--- a/src/include/cbmem.h
+++ b/src/include/cbmem.h
@@ -71,9 +71,8 @@ void cbmem_top_init(void);
/* Return the top address for dynamic cbmem. The address returned needs to
* be consistent across romstage and ramstage, and it is required to be
* below 4GiB for 32bit coreboot builds. On 64bit coreboot builds there's no
- * upper limit.
- * x86 boards or chipsets must return NULL before the cbmem backing store has
- * been initialized. */
+ * upper limit. This should not be called before memory is initialized.
+ */
void *cbmem_top(void);
/* Add a cbmem entry of a given size and id. These return NULL on failure. The