summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorFrans Hendriks <fhendriks@eltan.com>2019-12-06 16:00:20 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-12-10 11:19:30 +0000
commit18aa6fe26123c5fa4bc5439e4eb237b1cc5d86e4 (patch)
tree88fac7a03aa83320542d32bcc7a3b91c3ea3e4ef /src
parent263f129a8e1d012c53733170acaf9d0a01886b10 (diff)
downloadcoreboot-18aa6fe26123c5fa4bc5439e4eb237b1cc5d86e4.tar.xz
mb/{facebook/portwell}: Remove ITE8258_CMD_PORT
ITE8258_CMD_PORT is used in com_init.c only. Replace ITE8258_CMD_PORT by fixed value in the c file. ITE8258_DATA_PORT is removed as this isn't used. BUG=N/A TEST=build Change-Id: I401da3f127db9e65763fd8d115eb274fbadbefbe Signed-off-by: Wim Vervoorn <wvervoorn@eltan.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37609 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/facebook/fbg1701/com_init.c3
-rw-r--r--src/mainboard/facebook/fbg1701/onboard.h3
-rw-r--r--src/mainboard/portwell/m107/com_init.c3
-rw-r--r--src/mainboard/portwell/m107/onboard.h2
4 files changed, 2 insertions, 9 deletions
diff --git a/src/mainboard/facebook/fbg1701/com_init.c b/src/mainboard/facebook/fbg1701/com_init.c
index f19aba311c..fc640dd236 100644
--- a/src/mainboard/facebook/fbg1701/com_init.c
+++ b/src/mainboard/facebook/fbg1701/com_init.c
@@ -17,9 +17,8 @@
#include <bootblock_common.h>
#include <device/pnp_ops.h>
-#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */
+#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void)
{
diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h
index c22a63a04a..6e094ab6e9 100644
--- a/src/mainboard/facebook/fbg1701/onboard.h
+++ b/src/mainboard/facebook/fbg1701/onboard.h
@@ -21,9 +21,6 @@
/* SD CARD gpio */
#define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E
-#define ITE8528_DATA_PORT 0x6F
-
/* Define the items to be measured or verified */
#define FSP (const char *)"fsp.bin"
#define CMOS_LAYOUT (const char *)"cmos_layout.bin"
diff --git a/src/mainboard/portwell/m107/com_init.c b/src/mainboard/portwell/m107/com_init.c
index f19aba311c..fc640dd236 100644
--- a/src/mainboard/portwell/m107/com_init.c
+++ b/src/mainboard/portwell/m107/com_init.c
@@ -17,9 +17,8 @@
#include <bootblock_common.h>
#include <device/pnp_ops.h>
-#include "onboard.h"
-#define SERIAL_DEV PNP_DEV(ITE8528_CMD_PORT, 1) /* ITE8528 UART1 */
+#define SERIAL_DEV PNP_DEV(0x6E, 1) /* ITE8528 UART1 */
void bootblock_mainboard_early_init(void)
{
diff --git a/src/mainboard/portwell/m107/onboard.h b/src/mainboard/portwell/m107/onboard.h
index fd4e4d6516..3a5dee2f12 100644
--- a/src/mainboard/portwell/m107/onboard.h
+++ b/src/mainboard/portwell/m107/onboard.h
@@ -21,6 +21,4 @@
/* SD CARD gpio */
#define SDCARD_CD 81 /* Not used */
-#define ITE8528_CMD_PORT 0x6E
-#define ITE8528_DATA_PORT 0x6F
#endif