summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-04-19 15:33:08 -0500
committerAaron Durbin <adurbin@chromium.org>2016-04-21 20:42:20 +0200
commit60eb2c2c40193c457268aaa835002785b357df96 (patch)
tree0eeb5e257013f19399bc98cce987b47c348ddf09 /src
parenta0546da57a79499662f9f82590d1ef6fa18ed893 (diff)
downloadcoreboot-60eb2c2c40193c457268aaa835002785b357df96.tar.xz
arch: only print cbmem entries in one place
Each arch was calling cbmem_list() in their own write_tables() function. Consolidate that call and place it in common code in write_coreboot_table(). Change-Id: If0d4c84e0f8634e5cef6996b2be4a86cc83c95a9 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/14430 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src')
-rw-r--r--src/arch/arm/tables.c3
-rw-r--r--src/arch/arm64/tables.c3
-rw-r--r--src/arch/mips/tables.c3
-rw-r--r--src/arch/power8/tables.c3
-rw-r--r--src/arch/riscv/tables.c3
-rw-r--r--src/arch/x86/tables.c3
-rw-r--r--src/lib/coreboot_table.c3
7 files changed, 3 insertions, 18 deletions
diff --git a/src/arch/arm/tables.c b/src/arch/arm/tables.c
index 17a3fd1647..eb08e6e842 100644
--- a/src/arch/arm/tables.c
+++ b/src/arch/arm/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
new_table_pointer - table_pointer);
post_code(0x9e);
-
- /* Print CBMEM sections */
- cbmem_list();
}
void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/arm64/tables.c b/src/arch/arm64/tables.c
index 17a3fd1647..eb08e6e842 100644
--- a/src/arch/arm64/tables.c
+++ b/src/arch/arm64/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
new_table_pointer - table_pointer);
post_code(0x9e);
-
- /* Print CBMEM sections */
- cbmem_list();
}
void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/mips/tables.c b/src/arch/mips/tables.c
index 2083442f29..a3d9939707 100644
--- a/src/arch/mips/tables.c
+++ b/src/arch/mips/tables.c
@@ -51,9 +51,6 @@ void write_tables(void)
new_table_pointer - table_pointer);
post_code(0x9e);
-
- /* Print CBMEM sections */
- cbmem_list();
}
void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/power8/tables.c b/src/arch/power8/tables.c
index 0a885053a0..02d1c163e1 100644
--- a/src/arch/power8/tables.c
+++ b/src/arch/power8/tables.c
@@ -51,9 +51,6 @@ void write_tables(void)
new_table_pointer - table_pointer);
post_code(0x9e);
-
- /* Print CBMEM sections */
- cbmem_list();
}
void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/riscv/tables.c b/src/arch/riscv/tables.c
index 17a3fd1647..eb08e6e842 100644
--- a/src/arch/riscv/tables.c
+++ b/src/arch/riscv/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
new_table_pointer - table_pointer);
post_code(0x9e);
-
- /* Print CBMEM sections */
- cbmem_list();
}
void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c
index 8cfd6555a0..5780cd1dfe 100644
--- a/src/arch/x86/tables.c
+++ b/src/arch/x86/tables.c
@@ -212,7 +212,4 @@ void write_tables(void)
write_coreboot_table(low_table_start, low_table_end,
rom_table_start, rom_table_end);
}
-
- /* Print CBMEM sections */
- cbmem_list();
}
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index eeed65e744..18e8b342b6 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -572,6 +572,9 @@ unsigned long write_coreboot_table(
/* Add all cbmem entries into the coreboot tables. */
cbmem_add_records_to_cbtable(head);
+ /* Print CBMEM sections */
+ cbmem_list();
+
/* Remember where my valid memory ranges are */
return lb_table_fini(head);
}