diff options
| author | Ronald G. Minnich <rminnich@gmail.com> | 2013-05-03 18:25:27 +0200 |
|---|---|---|
| committer | Ronald G. Minnich <rminnich@gmail.com> | 2013-05-10 17:33:49 +0200 |
| commit | 711a6fde0db2f7a0c388fc97faec1013caaa2789 (patch) | |
| tree | 7c830d4aa59b8204b858710b30134ac31da0eb39 /util/abuild | |
| parent | c5e036a04368186fe73925c6fb101c594513391c (diff) | |
| download | coreboot-711a6fde0db2f7a0c388fc97faec1013caaa2789.tar.xz | |
Get rid of MAXIMUM_CONSOLE_LOGLEVEL; compile all messages into the coreboot binary
This option has never had much if any use. It solved a problem over 10
years ago that resulted from an argument over the value or lack thereof
of including all the debug strings in a coreboot image. The answer is
in: it's a good idea to maintain the capability to print all messages,
for many reasons.
This option is also misleading people, as in a recent discussion, to
believe that log messges are controlled at build time in a way they are
not. For the record, from this day forward, we can print messages at all
log levels and the default log level is set at boot time, as directed by
DEFAULT_CONSOLE_LOGLEVEL. You can set the default to 0 at build time and
if you are having trouble override it in CMOS and get more messages.
Besides, a quick glance shows it's always set to max (9 in this case) in
the very few cases (1) in which it is set.
Change-Id: I60c4cdaf4dcd318b841a6d6c70546417c5626f21
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: http://review.coreboot.org/3188
Tested-by: build bot (Jenkins)
Diffstat (limited to 'util/abuild')
| -rwxr-xr-x | util/abuild/abuild | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/util/abuild/abuild b/util/abuild/abuild index 1c69eec581..aad066cf73 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -596,8 +596,6 @@ while true ; do -C|--config) shift; configureonly=1;; -l|--loglevel) shift customizing="${customizing}, loglevel $1" - configoptions="${configoptions}CONFIG_MAXIMUM_CONSOLE_LOGLEVEL_$1=y\n" - configoptions="${configoptions}CONFIG_MAXIMUM_CONSOLE_LOGLEVEL=$1\n" configoptions="${configoptions}CONFIG_DEFAULT_CONSOLE_LOGLEVEL_$1=y\n" configoptions="${configoptions}CONFIG_DEFAULT_CONSOLE_LOGLEVEL=$1\n" shift;; |