diff options
author | Nico Huber <nico.h@gmx.de> | 2021-03-07 13:15:35 +0100 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2021-03-13 13:26:16 +0000 |
commit | de85f5ce2a23552ff53959782f907062858a623f (patch) | |
tree | 3594f344f48d7adebbb2534c53ac86f37c486a06 /util/board_status | |
parent | 21666e4611322f51fc9c291701f1cd89a6497f43 (diff) | |
download | coreboot-de85f5ce2a23552ff53959782f907062858a623f.tar.xz |
soc/intel/fast_spi/Makefile: Rewrite 16mib check for legibility
Perform some cosmetical changes:
* Override the first prerequisite so we can use `$<`.
* Add/remove whitspace to align things (recipe needs to be indented
by a single tab only).
* We can use shell variables inside double quotes. To make the
end of the variable name clear, use braces, e.g. "${x}".
NB. Most of the double quotes are unnecessary. They only change
the way the script would be failing in case of spurious whitespace.
* Break some lines doing multiple things at once.
* To reduce remaining clutter, put reading numbers into a shell
function.
And functional changes:
* No need to spawn `cat`, the shell can redirect input as well as
output (using `<`).
* To read a number from the `fmap_config.h`, we spawned 4 processes
where a single one can achieve the same. With one exception: GNU
awk refuses to parse hex numbers by default. Luckily, it turned
out that we don't need intermediate decimal numbers: Shells can
do arithmetic with hex values as well.
Change-Id: Ia7bfba0d7864fc091ee6003e09b705fd7254e99b
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51325
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'util/board_status')
0 files changed, 0 insertions, 0 deletions