summaryrefslogtreecommitdiff
path: root/util/board_status
diff options
context:
space:
mode:
authorMartin Roth <martin.roth@se-eng.com>2014-07-10 15:02:19 -0600
committerMartin Roth <gaumless@gmail.com>2014-07-21 17:36:58 +0200
commitbcd09930d8ff78704cb98ad18805788d02687a31 (patch)
treec2f1f15e1a76a8731b766482ab971760489c245c /util/board_status
parent8e0071b7982f5f72cc8e182f8eb5d77248f0b720 (diff)
downloadcoreboot-bcd09930d8ff78704cb98ad18805788d02687a31.tar.xz
board_status.sh minor fixes - no functional changes
- Update some comments - Whitespace fixes - change from backticks to $() format for getting command data. Change-Id: Iaf424224abfd30a3581d0e43a1689cc7c887beec Signed-off-by: Martin Roth <martin.roth@se-eng.com> Reviewed-on: http://review.coreboot.org/6261 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-by: David Hendricks <dhendrix@chromium.org>
Diffstat (limited to 'util/board_status')
-rwxr-xr-xutil/board_status/board_status.sh13
1 files changed, 8 insertions, 5 deletions
diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index ff95dd8867..373f8e3070 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -24,7 +24,8 @@ NONFATAL=1
# test a command
#
-# $1: test command on remote host (0=no, 1=yes)
+# $1: 0 ($LOCAL) to run command locally,
+# 1 ($REMOTE) to run remotely if remote host defined
# $2: command to test
# $3: 0 ($FATAL) Exit with an error if the command fails
# 1 ($NONFATAL) Don't exit on command test failure
@@ -37,7 +38,7 @@ test_cmd()
fi
if [ "$1" -eq "$REMOTE" ] && [ -n "$REMOTE_HOST" ]; then
- ssh root@${REMOTE_HOST} which "$2" >/dev/null
+ ssh root@${REMOTE_HOST} which "$2" > /dev/null
rc=$?
else
which "$2" >/dev/null
@@ -79,7 +80,8 @@ _cmd()
# run a command
#
-# $1: 0 to run command locally, 1 to run remotely if remote host defined
+# $1: 0 ($LOCAL) to run command locally,
+# 1 ($REMOTE) to run remotely if remote host defined
# $2: command
# $3: filename to direct output of command into
cmd()
@@ -97,7 +99,8 @@ cmd()
# run a command where failure is considered to be non-fatal
#
-# $1: 0 to run command locally, 1 to run remotely if remote host defined
+# $1: 0 ($LOCAL) to run command locally,
+# 1 ($REMOTE) to run remotely if remote host defined
# $2: command
# $3: filename to direct output of command into
cmd_nonfatal()
@@ -253,7 +256,7 @@ cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt"
#
# Finish up.
#
-coreboot_dir=`pwd`
+coreboot_dir=$(pwd)
if [ $UPLOAD_RESULTS -eq 1 ]; then
# extract username from ssh://<username>@review.coreboot.org/blah
username=$(git config --get remote.origin.url | sed 's/ssh\:\/\///' | sed 's/@.*//')