diff options
| author | Sol Boucher <solb@chromium.org> | 2015-05-07 21:12:28 -0700 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-05-13 22:24:39 +0200 |
| commit | 6310ccc59c1fd87ec5f68c1b0681e70500261e08 (patch) | |
| tree | fb1f0ead736a9f91697606eae6bb08f3a0591025 /util/cbfstool/cbfs-mkpayload.c | |
| parent | 67d5998d9778ef6f740aac4ed1c93fb311b32ebe (diff) | |
| download | coreboot-6310ccc59c1fd87ec5f68c1b0681e70500261e08.tar.xz | |
cbfstool: Don't typedef the comp_algo enum
Our style discourages unnecessary typedefs, and this one doesn't gain
us anything, nor is it consistent with the surrounding code: there's
a function pointer typedef'd nearby, but non-opaque structs aren't.
BUG=chromium:482652
TEST=None
BRANCH=None
Change-Id: Ie7565240639e5b1aeebb08ea005099aaa3557a27
Signed-off-by: Sol Boucher <solb@chromium.org>
Original-Change-Id: I4285e6b56f99b85b9684f2b98b35e9b35a6c4cb7
Original-Signed-off-by: Sol Boucher <solb@chromium.org>
Reviewed-on: http://review.coreboot.org/10146
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'util/cbfstool/cbfs-mkpayload.c')
| -rw-r--r-- | util/cbfstool/cbfs-mkpayload.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index 6eebbef9d0..5bebf51440 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -68,7 +68,7 @@ void xdr_get_seg(struct cbfs_payload_segment *out, } int parse_elf_to_payload(const struct buffer *input, struct buffer *output, - comp_algo algo) + enum comp_algo algo) { Elf64_Phdr *phdr; Elf64_Ehdr ehdr; @@ -249,7 +249,7 @@ int parse_flat_binary_to_payload(const struct buffer *input, struct buffer *output, uint32_t loadaddress, uint32_t entrypoint, - comp_algo algo) + enum comp_algo algo) { comp_func_ptr compress; struct cbfs_payload_segment segs[2]; @@ -293,8 +293,8 @@ int parse_flat_binary_to_payload(const struct buffer *input, return 0; } -int parse_fv_to_payload(const struct buffer *input, - struct buffer *output, comp_algo algo) +int parse_fv_to_payload(const struct buffer *input, struct buffer *output, + enum comp_algo algo) { comp_func_ptr compress; struct cbfs_payload_segment segs[2]; |