diff options
| author | Sol Boucher <solb@chromium.org> | 2015-05-05 15:40:15 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-05-08 20:23:23 +0200 |
| commit | 3e060ed112c5ec3a5fa58b68174dd57708af1d89 (patch) | |
| tree | f0b940cf9e72e9c5120764d281556c9440d7f8c8 /util/cbfstool/cbfstool.c | |
| parent | 297c88c35748ecd1f82fc96b71e10b118c587c71 (diff) | |
| download | coreboot-3e060ed112c5ec3a5fa58b68174dd57708af1d89.tar.xz | |
cbfstool: Fix leak in cbfs_image struct initialization
This patches a memory leak on every struct cbfs_image creation that
was introduced by c1d1fd850ee7b8e52bd2ea5064fab68ac0c27098. Since that
commit, the CBFS master header has been copied to a separate buffer so
that its endianness could be fixed all at once; unfortunately, this
buffer was malloc()'d but never free()'d. To address the issue, we
replace the structure's struct cbfs_header * with a struct cbfs_header
to eliminate the additional allocation.
Change-Id: Ie066c6d4b80ad452b366a2a95092ed45aa55d91f
Signed-off-by: Sol Boucher <solb@chromium.org>
Reviewed-on: http://review.coreboot.org/10130
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'util/cbfstool/cbfstool.c')
| -rw-r--r-- | util/cbfstool/cbfstool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index db521d67f5..024c9cfc25 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -465,7 +465,7 @@ static int cbfs_locate(void) } if (param.top_aligned) - address = address - image.header->romsize; + address = address - image.header.romsize; cbfs_image_delete(&image); printf("0x%x\n", address); |